id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
331	ropp_fm_abel consistency fix	Ian Culverwell	Ian Culverwell	"An internal ROPP7.0 beta reviewer noted that

{{{
However, I noticed a *minor inconsistency* between equation 4.27,
extrapolating above the model, and the actual code in 
ropp_fm_abel.f90:

IF (i == n_lev - 1) THEN
t_upper = SQRT(kval(i) * (nr(i+1) + 1.0d5 - impact(l)))
ELSE
t_upper = SQRT(kval(i) * (nr(i+1) - impact(l)))
ENDIF

This adds 100 km to the uppermost model level, and effectively 
erf(t_upper)~1.0 as stated in the text. However, the code could be 
made consistent with 4.27 by adding a line

IF (i == n_lev - 1) erf_up = 1.0_wp

As noted above, this is minor and is unlikely to have any impact on 
simulated values.

}}}

We should remove this inconsistency between code and documentation.
"	enhancement	closed	minor	7.1	ropp_fm	7.0	fixed	erf_up, ropp_fm_abel	sti cburrows