﻿id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
348	Bug-fix to ropp_pp_cutoff_amplitude	Ian Culverwell	Ian Culverwell	"While researching #301, Stig Syndergaard (DMI) found a small bug in Section 3.1 of '''ropp_pp_cutoff_amplitude''':

{{{
     DO i=1,n
       IF (BTEST(LCF(i),3)) THEN
         imax = MIN(i, imax)
         EXIT
       ENDIF
     ENDDO

...

     DO i=n,1,-1
       IF (BTEST(LCF(i),3)) THEN
         imin = MAX(i, imin)
         EXIT
       ENDIF
     ENDDO

}}}

should be replaced by

{{{
     DO i=1,n
       IF (BTEST(LCF(i),3)) THEN
         imax = MIN(i-1, imax)
         EXIT
       ENDIF
     ENDDO

...

     DO i=n,1,-1
       IF (BTEST(LCF(i),3)) THEN
         imin = MAX(i+1, imin)
         EXIT
       ENDIF
     ENDDO

}}}

This means that one too many data points get through the cut-off.

The bug probably has little impact - it doesn't in a quick test - but should nevertheless be put right. 
"	defect	closed	normal	8.0	ROPP (all)	7.0	fixed		Stig Syndergaard
