id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
412	Prevent tests of eum2bufr when MOBUFR is present	Ian Culverwell		"If ECMWF BUFR and METO BUFR are both installed (unlikely), the latter takes precedence.  The '''eum2bufr''' tools are designed to be used with the ECMWF BUFR library, and should not be tested with the METO BUFR.  We should therefore update the test logic in '''ropp_io/tests/Makefile.am''' from
{{{
if HAVE_ECMWF_BUFR
test_ecbufr: ./t_ropp2bufr
	@ echo """"
	@ echo ""Testing BUFR encode/decode [ECMWF library] ...""
	@ echo """"
	@ ./t_ropp2bufr
	@ echo """"
if HAVE_HDF5
test_eum2bufr: ./t_eum2bufr
	@ echo """"
	@ echo ""Testing BUFR encode/decode [EUM netCDF4 files] ...""
	@ echo """"
	@ ./t_eum2bufr
	@ echo """"
else
test_eum2bufr:;	@ echo """"
endif
else
test_ecbufr:;	@ echo """"
test_eum2bufr:;	@ echo """"
endif
}}}

to something like

{{{
if HAVE_ECMWF_BUFR
test_ecbufr: ./t_ropp2bufr
	@ echo """"
	@ echo ""Testing BUFR encode/decode [ECMWF library] ...""
	@ echo """"
	@ ./t_ropp2bufr
	@ echo """"
if HAVE_HDF5
if HAVE_METO_BUFR
test_eum2bufr:;	@ echo """"
else
test_eum2bufr: ./t_eum2bufr
	@ echo """"
	@ echo ""Testing BUFR encode/decode [EUM netCDF4 files] ...""
	@ echo """"
	@ ./t_eum2bufr
	@ echo """"
endif
else
test_eum2bufr:;	@ echo """"
endif
else
test_ecbufr:;	@ echo """"
test_eum2bufr:;	@ echo """"
endif
}}}

Or perhaps we should change 
{{{
if test x$HAVE_LIBRARY_bufr = xyes ; then
  if test x$HAVE_LIBRARY_metdbbufr = xyes ; then
    AC_MSG_NOTICE([Both MetDB & ECMWF BUFR libraries found; using MetDB in preference])
    AM_CONDITIONAL(HAVE_ECMWF_BUFR, test x$HAVE_LIBRARY_bufr = xno)
    AS_VAR_SET(HAVE_LIBRARY_bufr, no)
    LIBS=""$NO_ECMWF_LIBS""
  fi
fi
}}}
to
{{{
if test x$HAVE_LIBRARY_bufr = xyes ; then
  if test x$HAVE_LIBRARY_metdbbufr = xyes ; then
    AC_MSG_NOTICE([Both MetDB & ECMWF BUFR libraries found; using MetDB in preference])
    AM_CONDITIONAL(HAVE_ECMWF_BUFR, test x$HAVE_LIBRARY_bufr = xno)
    AS_VAR_SET(HAVE_LIBRARY_bufr, no)
    AS_VAR_SET(HAVE_ECMWF_BUFR, no)
    LIBS=""$NO_ECMWF_LIBS""
  fi
fi
}}}
in '''ropp_io/configure.ac'''.

Note that errors apparently arising from this do not, worryingly, appear to be reproducible.  Should we be using if tests on $HAVE_LIBRARY_bufr in '''Makefile.am''' instead?  The whole thing needs looking at - at ROPP9.0."	defect	closed	normal	11.1	ropp_io	8.0	fixed		olewis