id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
426	Rearrange calls to ropp_fm_refrac_1d	Ian Culverwell	Ian Culverwell	"I don't think we should be doing all the following in the high level routine ''ropp_fm_bg2ro_1d'':

{{{
        IF (state%new_ref_op) THEN
          CALL ropp_fm_refrac_1d_new(state, obs_refrac)
        ELSE
          CALL ropp_fm_refrac_1d(state, obs_refrac)
        END IF
}}}

Since {{{state%new_ref_op}}} is clearly an element of {{{state}}}, I think we should just
{{{
          CALL ropp_fm_refrac_1d(state, obs_refrac)
}}}

where ''ropp_fm_refrac_1d'' is a very simple subroutine that just says something like

{{{
        IF (state%new_ref_op) THEN
          CALL ropp_fm_refrac_1d_new(state, obs_refrac)
        ELSE
          CALL ropp_fm_refrac_1d_old(state, obs_refrac)
        END IF
}}}

These two routines would be held in separate files. (''ropp_fm_refrac_1d_new'' already is.)  

Check with Chris and Sean before doing this."	enhancement	closed	normal	11.0	ROPP (all)	8.0	wontfix