id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
430	Fix bug in OmA and OmB diagnostics	Ian Culverwell	Ian Culverwell	"One can sometimes find (eg attached)

{{{
*** max(omb), min(omb) =   9.99990e+07 -9.99990e+07
*** max(oma), min(oma) =   9.99990e+07 -9.99990e+07
}}}

when examining the diagnostic output variables ''OmB'' and ''OmA'' from '''ropp_1dvar_{bangle/refrac}'''.  The -ropp_MDFV values presumably come from unmasked missing A (or B) values being used in the differencing.

This can probably (needs checking) be cured by replacing
{{{
  WHERE (obs % bangle > ropp_MDTV)
     diag % OmA = (obs % bangle - diag % res_bangle % bangle)
  ELSEWHERE
     diag % OmA = ropp_MDFV
  END WHERE
}}}

with

{{{
  WHERE ( (obs % bangle > ropp_MDTV) .AND. &
          (diag % res_bangle % bangle > ropp_MDTV) ) 
     diag % OmA = (obs % bangle - diag % res_bangle % bangle)
  ELSEWHERE
     diag % OmA = ropp_MDFV
  END WHERE
}}}

in '''ropp_1dvar_diagnostics.f90'''.  Similarly for ''OmB'' in '''ropp_qc_omb.f90'''.

"	defect	closed	normal	9.0	ropp_1dvar	8.0	fixed