id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
694	Review PCD settings in ropp_1dvar_refrac/bangle	Ian Culverwell		"Stig Syndergaard (DMI) says:
{{{
I found another small issue in ropp_1dvar_refrac. When res_data 
is initially set to bg_data, also the PCD bit 15 is copied, 
indicating that res_data is a background profile, which it is not. I 
solved the problem in our dmi_trunk by removing the line:
}}}
https://trac.romsaf.org/ropp/changeset/6546/ropp_src/branches/dev/Share/dmi_trunk_10.0
{{{
I don't think the line is needed, as res_data is initialised with the 
default values from the type definition. Note that in the dmi_trunk we 
have (and also had in dmi_trunk_9.1) an assignment to the PCD in 
section 13.1 that works fine without any pre-initialisation other than 
from the type definition. So it seems safe to just delete the line. 
}}}

The lines of dmi_trunk that he means are
{{{
   res_data%PCD = obs_data%PCD
   IF (BTEST(obs_data%PCD,PCD_refrac)) THEN
     res_data%PCD = IBSET(res_data%PCD,PCD_met)
   ENDIF
}}}
Note that {{{res_data}}} is initialised to 65535 (i.e., all bits set), so this could have an effect.

A similar situation applies to '''ropp_1dvar_bangle'''.

Agreed to defer the discussion until ROPP-11.0.
"	task	assigned	normal	12.0	ropp_1dvar	10.0			Stig Syndergaard