Inconsitent handling of Earth's radius and undulation in ropp_fm

[frae]

tools/ecmwf2ro_1d.f90 approximates the Earth radius by setting it to the radius from the Smithonian tables while common/ropp_fm_roprof2obs.f90 uses the radius of curvature from the input netCDF file. Also, the latter uses the undulation as a correction to the radius of curvature while the former does not.

[frae]

Fixed in revision [1119] by setting Earth's radius now consistently to the Smithonian R_err_smt value. Undulation is now removed from the radius of curvature calculation, also making the FM more consistent. It still needs to be accessed if the undulation correction is needed in the radius of curvature, and if not, the code should be modified and r_curve_corr should be renamed. I left a FIXME in front of the statements in both routines: ropp_fm/common/ropp_fm_types.f90 and ropp_fm/tools/ecmwf2ro_1d.f90. Ticket remains open for now!

[(none)]

Milestone 2.0 deleted

[Huw Lewis]

Undulation correction in all modules reviewed (see #137). Close ticket as fixed.