Opened 19 years ago

Closed 18 years ago

Last modified 16 years ago

#23 closed defect (fixed)

Upper or lower case modfile name solution

Reported by: frae Owned by: marq
Priority: major Milestone:
Component: ROPP (all) Version: 0.8
Keywords: Cc: dave.offiler@…, carlo.buontempo@…, axel.vonengeln@…

Description

The current way to determine whether generated mod files have upper or lower case is not working for all compilers, e.g. the efc fails. I have implemented a quick and dirty solution directly into the configure files, thus I can start the testing. They are in revision 665, and allow to pass variables MOD_NAMES_UPCASE or MOD_NAMES_LOWCASE to the configure script. configure just does a test if one of the 2 is set and overwrites anything coming from the previous test. The solution might be overwritten with an update to configure but at least I can do some more testing ;-)

The solution looks like this:

# overwrite mod name convention, quick and dirty
# and should really be in configure.ac. Does the
# job for efc compiler.
if test -n "$MOD_NAMES_UPCASE"; then
  echo 'Found user set upper case module file.'
  CM_FC_UC_MODNAMES=yes
else
  if test -n "$MOD_NAMES_LOWCASE"; then
     echo 'Found user set lower case module file.'
     CM_FC_UC_MODNAMES=no
  fi
fi

Change history (6)

comment:1 by marq, 19 years ago

Cc: axel.vonengeln@… dave.offiler@… added
Owner: changed from frcm to marq
Status: newassigned

With changeset [694], configure gets two new command line arguments, --with-uppercase-modnames and --with-lowercase-modnames. These can be used to overwrite the default settings when configure is run. Together with the improvements in the compiler detection, this should suffice for most cases (although it still isn't an automated version). So I leave this open for the time being...

comment:2 by marq, 19 years ago

Cc: carlo.buontempo@… axel.vonengeln@… added; axel.vonengeln@… removed
Version: 1.0

comment:3 by marq, 19 years ago

Milestone: 1.00.9
Priority: normalhigh
severity: normalminor

comment:4 by marq, 18 years ago

Resolution: fixed
Status: assignedclosed

I have not heard anything against this solution for more than half a year, so I consider the problem fixed with the solution implemented in r694.

comment:5 by Dave Offiler, 18 years ago

Version: 0.8

comment:6 by (none), 16 years ago

Milestone: 0.9

Milestone 0.9 deleted

Note: See TracTickets for help on using tickets.