Opened 13 years ago

Closed 13 years ago

#237 closed defect (fixed)

ropp_pp_openloop wrong calculation of correlation between data and external navbits

Reported by: kmk Owned by: Ian Culverwell
Priority: minor Milestone: 5.1
Component: ropp_pp Version: 4.1
Keywords: Cc: kmk@…

Description

ropp_pp_openloop line 193:

ni = SUM(DNB(kmin:kmax+i)**2)

should be:

ni = SUM(DNB(kmin+i:kmax)**2)

The effect here is a potential miscalculation of the correlation between the external navigation bits and the data. I think this is a minor bug but it could have effects.

Change history (4)

comment:1 by kmk, 13 years ago

Milestone: 5.06.0

comment:2 by Ian Culverwell, 13 years ago

Owner: set to Ian Culverwell
Status: newassigned

comment:3 by Ian Culverwell, 13 years ago

Cc: kmk@… added
Milestone: 6.05.1

This has null impact in our tests, so hard to judge the impact. But if Kjartan is happy that it's a bug that's good enough for me. Going in at ROPP5.1

comment:4 by Ian Culverwell, 13 years ago

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.