Bug in new ropp_io/tests

[Dave Offiler]

'make test' in ropp_io fails to run the new test scripts (t_bgrasc2ropp[.sh], t_grib2bgrasc[.sh], t_eum2ropp[.sh] & t_eumbufr[.sh]) when installing from individual module tarballs.

All of these scripts include a check for the current directory:

if [ "$(basename $(dirname $PWD))"/"$(basename $PWD)" != "ropp_io/tests" ] ; then
  echo "*** Not in ropp_io/tests subdirectory - test NOT PERFORMED"
  exit
fi

which works for the full tarball, but not when installing from the individual module tarballs, where (in this case) the tree is ropp_io-6.1/tests.

Solutions (in reverse recommended order):

• arrange for the individual tarballs to extract to a tree without the version number (potentially overwriting a previous release unless untarred within a higher-level version-specific root directory)
• hard-code a check for ropp_io/tests and ropp_io-6.1/tests (which would have to be updated for every release)
• ditto, but detect the current version ID on the fly (messy)
• remove these checks entirely.

The failed check doesn't cause a 'make' error, and it's not a show-stopper - the user just gets a message that these tests haven't run, for no obvious reason. I don't understand what problem these checks are trying to solve; the other scripts don't have this check, and work OK. I suggest to simply remove the checks n these 4 test scripts.

[Dave Offiler]

Ian has amended these tests to only check the first 7 characters ('ropp_io')