open_loop_lcf is an integer

[Ian Culverwell]

... so perhaps it should be held as one in ROPP. (All "extra data" variables are currently stored as reals. Probably doesn't have any impact (it's read in with a NINT), hence its low priority.)

Should probably also change the misleading long name

OpenLoop Phase Model

to something more appropriate, like

Lost Carrier Flag.

[Ian Culverwell]

Changing the long name is not too difficult, as it only affects ropp_io/ropp/ropp_io_read_ncdf_get.f90 and ropp_pp/tools/ropp_pp_grasrs2ropp.f90. It works OK with the latter tool:

ncdump -h ropp_pp_test_gras.nc |grep open_loop
	double open_loop_lcf(dim_unlim, dim_lev1a) ;
		open_loop_lcf:long_name = "OpenLoop Phase Model" ;
		open_loop_lcf:units = "1" ;
		open_loop_lcf:valid_range = -1000000., 1000000. ;

becomes

ncdump -h ropp_pp_test_gras.nc |grep open_loop                                                
	double open_loop_lcf(dim_unlim, dim_lev1a) ;
		open_loop_lcf:long_name = "Lost Carrier Flag" ;
		open_loop_lcf:units = "1" ;
		open_loop_lcf:valid_range = -1000000., 1000000. ;

This change has been made at r4211.

[Ian Culverwell]

But writing a whole set of "add extra integer variable" routines would be a fair bit of work for not (currently) much reward. I suggest 'parking' that aspect until we have another integer we wish to add, which would make the effort worthwhile. Leaving the ticket to be fixed "whenever".