Remove redundant variables

[Ian Culverwell]

The nagfor compiler provides lots of useful information about redundant variables, like

NAG Fortran Compiler Release 5.2(721)
Warning: ../qc/ropp_qc_ion_bangle.f90, line 199: Unused dummy variable DIAG
         detected at ROPP_QC_ION_BANGLE@<end-of-statement>

Later versions provide more comprehensive checking, and include things like

NAG Fortran Compiler Release 5.3.1(907)
Questionable: ../qc/ropp_qc_omb.f90, line 135: Variable DUMMY set but never referenced

We should probably reduce the number of unused variable if possible Caution is required, however. For example, nagfor5.3 says

Warning: ../ropp/ropp_io_read_ncdf_get.f90, line 3465: Unused dummy variable FILE
Warning: ../ropp/ropp_io_read_ncdf_get.f90, line 3465: Unused local variable LDUM
Warning: ../ropp/ropp_io_read_ncdf_get.f90, line 3611: Unused dummy variable LDUMMY

The last of these is needed to let the operator overloading differentiate between ropp_io_read_ncdf_get_eumdata and ropp_io_read_ncdf_get_otherdata.

[Ian Culverwell]

The first tranche of these removals have been committed at r5118.

[Ian Culverwell]

I mean r5518.

[Ian Culverwell]

Some more have been made at r5547.

[Ian Culverwell]

Doesn't crash the overnight test folder, so close ticket.