#537 closed task (fixed)
Defined new sub-variables j_s_limit and n_iter_limit [0.5 d]
| Reported by: | Ian Culverwell | Owned by: | Ian Culverwell |
|---|---|---|---|
| Priority: | normal | Milestone: | ROPP9.1 carry over |
| Component: | ropp_1dvar | Version: | 9.0 |
| Keywords: | Cc: |
Description
https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_1dvar/common/ropp_1dvar_diagnostics.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_1dvar/common/ropp_1dvar_read_config.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_1dvar/common/ropp_1dvar_types.f90
Original changeset:
Defined new sub-variables j_s_limit and n_iter_limit: https://trac.romsaf.org/ropp/changeset/5068
Change history (8)
comment:1 by , 6 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:2 by , 6 years ago
| Component: | ROPP(all) → ropp_1dvar |
|---|
comment:3 by , 5 years ago
comment:4 by , 5 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
ROPP_1DVAR UG updated with these new parameters at r5890. Closing ticket.
comment:6 by , 5 years ago
(Some improvements to the written output, arising from this change, have been committed at r5958.)
comment:7 by , 5 years ago
(A change to increase ulimit to unlimited in test_1dvar_iono.sh has been made at r5959, because this test needs more than the 8192 Kibytes that are the RHEL7 default.)
comment:8 by , 5 years ago
We agreed at the ROPP CG meeting in Nov 2019 to revert j_s_limit to its previous default value of 5.0. This has been done at r6249. It causes no problems with the core tests.
Included at r5889. Note that the new parameters will retain their default values of
! Scaled cost function that 2J/m must not exceed REAL(wp) :: j_s_limit = 50_wp ! Number of iterations that must not be exceeded INTEGER :: n_iter_limit = 50as they aren't (yet) included in any of the standard configuration files.