Opened 6 years ago
Closed 5 years ago
#544 closed task (fixed)
Initializing lev1b and lev2a structures [1d ?]
| Reported by: | Ian Culverwell | Owned by: | Ian Culverwell |
|---|---|---|---|
| Priority: | normal | Milestone: | ROPP9.1 carry over |
| Component: | ropp_fm | Version: | 9.0 |
| Keywords: | Cc: |
Description
https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/build/Makefile.am https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/common/ropp_fm.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/refrac_1d/Makefile.am https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/refrac_1d/ropp_fm_tdry.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/refrac_1d/ropp_fm_tdry_1d.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/tools/ropp_fm_bg2ro_1d.f90
Original changesets:
Initializing lev1b and lev2a structures: https://trac.romsaf.org/ropp/changeset/4656/ropp_src/branches/dev/Share/dmi_trunk_8.0/ropp_fm/tools/ropp_fm_bg2ro_1d.f90
Change history (8)
comment:1 by , 6 years ago
| Component: | ROPP(all) → ropp_fm |
|---|
comment:2 by , 5 years ago
comment:4 by , 5 years ago
The second set cause the make tests to fail, because, for example:
Testing ropp_fm with 1D ECMWF background dataset
Running t_fm_1D_1 (FM 1D; default options) ...
----------------------------------------------------------------------
ROPP FM File Comparison Tool
----------------------------------------------------------------------
INFO (from ropp_fm_compare): Comparing ropp_fm_bgr20090401.nc and ../data/ropp_fm_bgr20090401_reference.nc:
the results of running test t_fm_1D_1 (FM 1D; default options)
ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%bangle_qual values ARE significantly different: |diff| = 1.00000E+02 > 1.00000E-06
ERROR (from ropp_io_fields_compare): Profile 1 Lev2a%refrac_qual values ARE significantly different: |diff| = 1.00000E+02 > 1.00000E-06
INFO (from ropp_fm_compare): Differences occurred in profile 1
ERROR (from ropp_io_fields_compare): Profile 2 Lev1b%bangle_qual values ARE significantly different: |diff| = 1.00000E+02 > 1.00000E-06
ERROR (from ropp_io_fields_compare): Profile 2 Lev2a%refrac_qual values ARE significantly different: |diff| = 1.00000E+02 > 1.00000E-06
INFO (from ropp_fm_compare): Differences occurred in profile 2
ERROR (from ropp_io_fields_compare): Profile 3 Lev1b%bangle_qual values ARE significantly different: |diff| = 1.00000E+02 > 1.00000E-06
ERROR (from ropp_io_fields_compare): Profile 3 Lev2a%refrac_qual values ARE significantly different: |diff| = 1.00000E+02 > 1.00000E-06
INFO (from ropp_fm_compare): Differences occurred in profile 3
ERROR (from ropp_io_fields_compare): Profile 4 Lev1b%bangle_qual values ARE significantly different: |diff| = 1.00000E+02 > 1.00000E-06
ERROR (from ropp_io_fields_compare): Profile 4 Lev2a%refrac_qual values ARE significantly different: |diff| = 1.00000E+02 > 1.00000E-06
INFO (from ropp_fm_compare): Differences occurred in profile 4
ERROR (from ropp_io_fields_compare): Profile 5 Lev1b%bangle_qual values ARE significantly different: |diff| = 1.00000E+02 > 1.00000E-06
ERROR (from ropp_io_fields_compare): Profile 5 Lev2a%refrac_qual values ARE significantly different: |diff| = 1.00000E+02 > 1.00000E-06
INFO (from ropp_fm_compare): Differences occurred in profile 5
INFO (from ropp_fm_compare): 10 elements of ropp_fm_bgr20090401.nc and ../data/ropp_fm_bgr20090401_reference.nc differ significantly
****************************
********** *FAIL* **********
****************************
... examine t_fm_1D_1.log for details
That seems fairy nuff: the quality flags are 0 in the reference files and 100 (%) in the test files. So I think it's safe to just amend the reference files.
comment:5 by , 5 years ago
However, when I do this, I find that it now passes where it failed before, but that it fails the t_iono test:
*** Results log of t_iono_1 (FM iono2) ***
./t_iono
Ne_max, H_peak, H_width = 3.00000E+11 3.00000E+05 7.50000E+04
RoC, r_LEO, und, lat = 6.35003E+06 7.15003E+06 1.29449E+01 -3.65360E+01
ii impact bangle_L1(test) bangle_L1(ref) bangle_L2(test) bangle_L2(ref)
1 2365.81 0.28312875E-01 0.28312882E-01 0.28322249E-01 0.28322261E-01
11 3764.98 0.24506560E-01 0.24506567E-01 0.24516010E-01 0.24516023E-01
21 5409.42 0.11645275E-01 0.11645283E-01 0.11654818E-01 0.11654830E-01
31 7178.12 0.11537614E-01 0.11537622E-01 0.11547258E-01 0.11547270E-01
41 8972.60 0.86063012E-02 0.86063087E-02 0.86160501E-02 0.86160625E-02
51 10824.44 0.68233146E-02 0.68233222E-02 0.68331742E-02 0.68331867E-02
61 12702.58 0.56243176E-02 0.56243252E-02 0.56342921E-02 0.56343046E-02
71 14598.90 0.42547296E-02 0.42547372E-02 0.42648228E-02 0.42648354E-02
81 16523.92 0.33218732E-02 0.33218809E-02 0.33320900E-02 0.33321027E-02
91 18463.34 0.24479512E-02 0.24479589E-02 0.24582955E-02 0.24583082E-02
101 20422.41 0.16899502E-02 0.16899579E-02 0.17004265E-02 0.17004393E-02
111 22400.60 0.11920791E-02 0.11920869E-02 0.12026922E-02 0.12027051E-02
121 24390.83 0.84509797E-03 0.84510581E-03 0.85585244E-03 0.85586535E-03
131 26390.37 0.61553958E-03 0.61554746E-03 0.62643984E-03 0.62645282E-03
141 28396.00 0.44073415E-03 0.44074207E-03 0.45178463E-03 0.45179768E-03
151 30407.02 0.32359674E-03 0.32360471E-03 0.33480204E-03 0.33481515E-03
161 32421.82 0.24234398E-03 0.24235198E-03 0.25370873E-03 0.25372190E-03
171 34439.65 0.18105336E-03 0.18106140E-03 0.19258235E-03 0.19259560E-03
181 36460.11 0.13569135E-03 0.13569943E-03 0.14738954E-03 0.14740285E-03
191 38482.89 0.10406130E-03 0.10406942E-03 0.11593384E-03 0.11594722E-03
201 40507.67 0.82264115E-04 0.82272277E-04 0.94316316E-04 0.94329760E-04
211 42534.18 0.66335510E-04 0.66343714E-04 0.78572900E-04 0.78586412E-04
221 44562.34 0.53814516E-04 0.53822762E-04 0.66242842E-04 0.66256422E-04
231 46592.07 0.45079874E-04 0.45088162E-04 0.57705119E-04 0.57718768E-04
241 48623.30 0.39373875E-04 0.39382205E-04 0.52202261E-04 0.52215980E-04
251 50655.94 0.35197102E-04 0.35205475E-04 0.48235107E-04 0.48248896E-04
261 52689.96 0.32055832E-04 0.32064248E-04 0.45310200E-04 0.45324060E-04
271 54725.35 0.29691749E-04 0.29700207E-04 0.43169503E-04 0.43183434E-04
281 56762.09 0.28086880E-04 0.28095382E-04 0.41795335E-04 0.41809337E-04
291 58800.17 0.26929211E-04 0.26937756E-04 0.40875980E-04 0.40890054E-04
Comparing against bending angles in ../data/bgr20090401_000329_M02_2030337800_N
0007_YYYY_iono_ref.nc
L1 bending angle comparison failed: max difference = 3.2742426E-02 %
L2 bending angle comparison failed: max difference = 3.5003923E-02 %
****************************
********** *FAIL* **********
****************************
What's going on?
comment:6 by , 5 years ago
This reference file was changed at r5789 as a result of the last minute sign change to the ne(LEO) effects. But that dosn't explain the above failure of t_iono with the new dataset, which only differed in bangle_qual etc.
comment:7 by , 5 years ago
The above is what you get when you just copy the test file to the reference file. Apparently the only difference is the bangle_qual etc being 100 instead of 0. But when I alter the reference file manually, using ncap2, t_iono works OK:
t_iono
Ne_max, H_peak, H_width = 3.00000E+11 3.00000E+05 7.50000E+04
RoC, r_LEO, und, lat = 6.35003E+06 7.15003E+06 1.29449E+01 -3.65360E+01
ii impact bangle_L1(test) bangle_L1(ref) bangle_L2(test) bangle_L2(ref)
1 2365.81 0.28312875E-01 0.28312875E-01 0.28322249E-01 0.28322249E-01
11 3764.98 0.24506560E-01 0.24506560E-01 0.24516010E-01 0.24516010E-01
21 5409.42 0.11645275E-01 0.11645275E-01 0.11654818E-01 0.11654818E-01
31 7178.12 0.11537614E-01 0.11537614E-01 0.11547258E-01 0.11547258E-01
41 8972.60 0.86063012E-02 0.86063012E-02 0.86160501E-02 0.86160501E-02
51 10824.44 0.68233146E-02 0.68233146E-02 0.68331742E-02 0.68331742E-02
61 12702.58 0.56243176E-02 0.56243176E-02 0.56342920E-02 0.56342920E-02
71 14598.90 0.42547296E-02 0.42547296E-02 0.42648228E-02 0.42648228E-02
81 16523.92 0.33218732E-02 0.33218732E-02 0.33320900E-02 0.33320900E-02
91 18463.34 0.24479512E-02 0.24479512E-02 0.24582955E-02 0.24582955E-02
101 20422.41 0.16899502E-02 0.16899502E-02 0.17004265E-02 0.17004265E-02
111 22400.60 0.11920791E-02 0.11920791E-02 0.12026922E-02 0.12026922E-02
121 24390.83 0.84509797E-03 0.84509797E-03 0.85585244E-03 0.85585244E-03
131 26390.37 0.61553958E-03 0.61553958E-03 0.62643983E-03 0.62643983E-03
141 28396.00 0.44073415E-03 0.44073415E-03 0.45178463E-03 0.45178463E-03
151 30407.02 0.32359674E-03 0.32359674E-03 0.33480204E-03 0.33480204E-03
161 32421.82 0.24234398E-03 0.24234398E-03 0.25370873E-03 0.25370873E-03
171 34439.65 0.18105336E-03 0.18105336E-03 0.19258235E-03 0.19258235E-03
181 36460.11 0.13569135E-03 0.13569135E-03 0.14738954E-03 0.14738954E-03
191 38482.89 0.10406130E-03 0.10406130E-03 0.11593384E-03 0.11593384E-03
201 40507.67 0.82264115E-04 0.82264115E-04 0.94316316E-04 0.94316316E-04
211 42534.18 0.66335510E-04 0.66335510E-04 0.78572900E-04 0.78572900E-04
221 44562.34 0.53814516E-04 0.53814516E-04 0.66242842E-04 0.66242842E-04
231 46592.07 0.45079874E-04 0.45079874E-04 0.57705119E-04 0.57705119E-04
241 48623.30 0.39373875E-04 0.39373875E-04 0.52202261E-04 0.52202261E-04
251 50655.94 0.35197102E-04 0.35197102E-04 0.48235107E-04 0.48235107E-04
261 52689.96 0.32055832E-04 0.32055832E-04 0.45310200E-04 0.45310200E-04
271 54725.35 0.29691749E-04 0.29691749E-04 0.43169503E-04 0.43169503E-04
281 56762.09 0.28086880E-04 0.28086880E-04 0.41795335E-04 0.41795335E-04
291 58800.17 0.26929211E-04 0.26929211E-04 0.40875980E-04 0.40875980E-04
Comparing against bending angles in ../data/bgr20090401_000329_M02_2030337800_N
0007_YYYY_iono_ref.nc
****************************
********** PASS **********
****************************
And we get a clean sweep of the make test results:
************************** SUMMARY OF ROPP_FM TEST RESULTS *************************** -------------------------------------------------------------------------------------- | Test name | Description | Run? | PASS? | -------------------------------------------------------------------------------------- | t_fascod_1 | FM FASCOD 1D | Run | PASS | | t_fascod_tl_1 | FM_TL FASCOD 1D | Run | PASS | | t_fascod_ad_1 | FM_AD FASCOD 1D | Run | PASS | | t_fascod_2 | FM FASCOD 1D -comp | Run | PASS | | t_fascod_tl_2 | FM_TL FASCOD 1D -comp | Run | PASS | | t_fascod_ad_2 | FM_AD FASCOD 1D -comp | Run | PASS | | t_fascod_3 | FM FASCOD 1D -new_op | Run | PASS | | t_fascod_tl_3 | FM_TL FASCOD 1D -new_op | Run | PASS | | t_fascod_ad_3 | FM_AD FASCOD 1D -new_op | Run | PASS | | t_fascod_4 | FM FASCOD 1D -comp -new_op | Run | PASS | | t_fascod_tl_4 | FM_TL FASCOD 1D -comp -new_op | Run | PASS | | t_fascod_ad_4 | FM_AD FASCOD 1D -comp -new_op | Run | PASS | | t_twodop_1 | FM TWOD | Run | PASS | | t_twodtl_1 | FM_TL TWOD | Run | PASS | | t_twodad_1 | FM_AD TWOD | Run | PASS | | t_twodop_2 | FM TWOD -comp | Run | PASS | | t_twodtl_2 | FM_TL TWOD -comp | Run | PASS | | t_twodad_2 | FM_AD TWOD -comp | Run | PASS | | t_iono_1 | FM L1 and L2 | Run | PASS | | t_iono_tl_1 | FM_TL L1 and L2 | Run | PASS | | t_iono_ad_1 | FM_AD L1 and L2 | Run | PASS | | t_fm_1D_1 | FM 1D; default options | Run | PASS | | t_fm_1D_2 | FM 1D; compress factors | Run | PASS | | t_fm_2D_1 | FM 2D; default options | Run | PASS | | t_fm_2D_2 | FM 2D; compress factors | Run | PASS | | t_fm_iono_1 | FM iono; L_neutral | Run | PASS | | t_fm_iono_2 | FM iono; L1 and L2 | Run | PASS | --------------------------------------------------------------------------------------
I don't understand this, but anyway, these changes to the test datasets have been committed at r5916.
Note:
See TracTickets
for help on using tickets.
There are two aspects to this ticket: only initialising the height elements of the 1b and 2a structures in ropp_fm_bg2ro_1d.f90, and the setting to
.TRUE.ofobs_refrac%obs_okandobs_bangle%obs_okat the end of subroutines set_obs_levels_refrac and set_obs_levels_bangle respectively. (Note that subroutine set_obs_levels_refrac_247, referred to in the original changeset, is no longer part of the ROPP trunk, having proved to be more trouble than it was worth some time ago.)