Opened 7 years ago
Closed 6 years ago
#564 closed task (wontfix)
Do not warn on the use of --no-ranchk [0.5 d]
| Reported by: | Ian Culverwell | Owned by: | Ian Culverwell |
|---|---|---|---|
| Priority: | normal | Milestone: | ROPP9.1 carry over |
| Component: | ropp_io | Version: | 9.0 |
| Keywords: | Cc: |
Description
Original changesets:
Do not warn on the use of --no-ranchk: https://trac.romsaf.org/ropp/changeset/4820
Change history (4)
comment:1 by , 6 years ago
comment:2 by , 6 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:3 by , 6 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
comment:4 by , 6 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | reopened → closed |
Note:
See TracTickets
for help on using tickets.

Presumably this breaks the DMI operational system because a WARNING delivers a return code,
$?, of 1. This feature - the association of ROPP messages with specific return codes - was introduced at DMI's request some time ago. Replacing the WARNING by an INFO message results in a return code of 0. That would also fix it. But it is risky to switch off range-checking, and I think general, inexpert users should be warned that they have done it rather than just told that they have.This really is just a problem for DMI. A better solution, for DMI, would be to replace
by
in ropp_utils/messages/messages.f90.
Check that this works for eum2ropp.
Before (
msg_exit_warn = 1):prompt:> ../tools/eum2ropp ../data/eum_test.n4 -l cl+rs -o eum_test_l.nc --------------------------------------------------------------------- EUMETSAT to ROPP netCDF Converter --------------------------------------------------------------------- INFO (from eum2ropp): Reading file ../data/eum_test.n4 INFO (from ropp_io_read_eumdata): raw_sampling data requested but are not available in file INFO (from eum2ropp): Profile 1 : OC_20120909000057_META_G015_EUME INFO (from eum2ropp): Writing eum_test_l.nc prompt:> echo $? 0 prompt:> ../tools/eum2ropp ../data/eum_test.n4 -l cl+rs -o eum_test_l.nc --no-ranchk --------------------------------------------------------------------- EUMETSAT to ROPP netCDF Converter --------------------------------------------------------------------- WARNING (from eum2ropp): Range checking is disabled INFO (from eum2ropp): Reading file ../data/eum_test.n4 INFO (from ropp_io_read_eumdata): raw_sampling data requested but are not available in file INFO (from eum2ropp): Profile 1 : OC_20120909000057_META_G015_EUME INFO (from eum2ropp): Writing eum_test_l.nc prompt:> echo $? 1After (
msg_exit_warn = 0):prompt:> ../tools/eum2ropp ../data/eum_test.n4 -l cl+rs -o eum_test_l.nc --------------------------------------------------------------------- EUMETSAT to ROPP netCDF Converter --------------------------------------------------------------------- INFO (from eum2ropp): Reading file ../data/eum_test.n4 INFO (from ropp_io_read_eumdata): raw_sampling data requested but are not available in file INFO (from eum2ropp): Profile 1 : OC_20120909000057_META_G015_EUME INFO (from eum2ropp): Writing eum_test_l.nc prompt:> echo $? 0 prompt:> ../tools/eum2ropp ../data/eum_test.n4 -l cl+rs -o eum_test_l.nc --no-ranchk --------------------------------------------------------------------- EUMETSAT to ROPP netCDF Converter --------------------------------------------------------------------- WARNING (from eum2ropp): Range checking is disabled INFO (from eum2ropp): Reading file ../data/eum_test.n4 INFO (from ropp_io_read_eumdata): raw_sampling data requested but are not available in file INFO (from eum2ropp): Profile 1 : OC_20120909000057_META_G015_EUME INFO (from eum2ropp): Writing eum_test_l.nc prompt:> echo $? 0This trick would of course have the effect of making all WARNINGS deliver a return code of
Not putting in official branch. Closing ticket.