Opened 6 years ago

Closed 5 years ago

#566 closed task (fixed)

Bug-fix [ 1h]

Reported by: Ian Culverwell Owned by: Ian Culverwell
Priority: normal Milestone: ROPP9.1 carry over
Component: ropp_io Version: 9.0
Keywords: Cc:

Description

https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/tools/ropp2ropp.f90

Original changesets:

Bug-fix: https://trac.romsaf.org/ropp/changeset/5374/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/tools/ropp2ropp.f90

Change history (1)

comment:1 by Ian Culverwell, 5 years ago

Resolution: → fixed
Status: new → closed

The bug-fix is unobjectionable.

I'm not sure what the point of the code snippet is. I suppose DMI found some cases where ROdata%Lev1a%Npoints was zero after thinning. But this can happen for other levels of data, too. In particular, lev2b is missing from 9 of the 11 thinning tests carried out by ropp_io/tests/t_roppthin.sh. So I guess this block of code might need extending at some point.

Regarding the other part: 

IF ( SIZE(ROdata%vlist) ) CALL ropp_io_free(ROdata%vlist)

I don't see why we should only do this if a thinning file is specified. I presume DMI had their reasons. Suggest we put it in and be prepared to pull out if it messes up some user's processing.

Committed at r6241. Closing ticket.

Note: See TracTickets for help on using tickets.