#601 closed task (fixed)
Make sure the uppermost grid point is inside the data interval [1 h]
| Reported by: | Ian Culverwell | Owned by: | Ian Culverwell |
|---|---|---|---|
| Priority: | normal | Milestone: | ROPP9.1 carry over |
| Component: | ropp_pp | Version: | 11.0 |
| Keywords: | Cc: |
Description
https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/build/Makefile.am https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/bangle/ropp_pp_bending_angle_go.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/preprocess/ropp_pp_cutoff.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/preprocess/ropp_pp_preproc.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/preprocess/ropp_pp_preprocess.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/preprocess/ropp_pp_preprocess_champ.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/preprocess/ropp_pp_preprocess_cosmic.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/preprocess/ropp_pp_preprocess_grasrs.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/tools/ropp_pp_spectra_tool.f90
Original changesets:
Make sure the uppermost grid point is inside the data interval: https://trac.romsaf.org/ropp/changeset/5343/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_pp/preprocess/ropp_pp_preprocess_grasrs.f90
Change history (3)
comment:1 by , 3 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
| Version: | 9.0 → 11.0 |
comment:2 by , 3 years ago
(Doesn't have any effect on the tests, because we're only adjusting the rule for calculating n1 and n, and these are integers. In this case they are clearly unchanged.)
comment:3 by , 3 years ago
(Just checked this, for the record:
old code: n1, n = 44011 47010 new code: n1, n = 44011 47010
As expected.)
The relevant bit of code defines the 'anchor point'
n1between the RS and CL sections of the occultation. Rising and setting, and RS+CL and pure CL, timeseries are treated.n1is used to define a merged profile time coordinate, which runs from the earliest to the latest available time, in steps of the RS period (if merging RS & CL data) or the CL period (if using pure CL data).The changeset involves recalculating
ts(see #600) before using it to (re-)calculaten1. When does it matter? I can't derive an example - and none given on the ticket.I might come back to this, but unlikely.
Checks out OK (i.e. has no effect on our tests).
Commit change at r6839.
Closing ticket.