Opened 7 years ago
Closed 3 years ago
#610 closed task (fixed)
Introducing gradual transitions to avoid kinks in profiles [2 d]
| Reported by: | Ian Culverwell | Owned by: | Ian Culverwell |
|---|---|---|---|
| Priority: | normal | Milestone: | ROPP9.1 carry over |
| Component: | ropp_pp | Version: | 11.0 |
| Keywords: | Cc: |
Description
Original changesets:
Introducing gradual transitions to avoid kinks in profiles: https://trac.romsaf.org/ropp/changeset/5164/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_pp/bangle/ropp_pp_dct.f90
Change history (4)
comment:1 by , 4 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
| Version: | 9.0 → 11.0 |
comment:2 by , 4 years ago
(Note that a cos2x + b sin2x can be written as (a+b)/2 + (a-b)/2 cos(2x), which is probably more efficient computationally - one transcendental function to evaluate, and no squaring.)
comment:3 by , 4 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Reopening ticket as Stig needs to review documentation change at r6827.
comment:4 by , 3 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Closing ticket as Stig is happy with the documentation.
Note:
See TracTickets
for help on using tickets.
Sounds like a good idea.
Affects occ, occ_gnos and rs tests:
Running t_pp_occ_1 (PP occ; default options) ... ---------------------------------------------------------------------- ROPP PP File Comparison Tool ---------------------------------------------------------------------- INFO (from ropp_pp_compare): Comparing ropp_pp_test_2m.nc and ../data/ropp_pp_test_2m_reference.nc: the results of running test t_pp_occ_1 (PP occ; default options) ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%bangle values ARE significantly different: |diff| = 2.57280E-05 > 1.00000E-05 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%bangle_opt values ARE significantly different: |diff| = 2.57278E-05 > 1.00000E-06 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%bangle_L1 values ARE significantly different: |diff| = 1.80562E-05 > 1.00000E-06 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%bangle_L2 values ARE significantly different: |diff| = 1.30930E-05 > 1.00000E-06 ERROR (from ropp_io_fields_compare): Profile 1 Lev2a%refrac values ARE significantly different: |diff| = 6.74622E-02 > 1.00000E-06 INFO (from ropp_pp_compare): Differences occurred in profile 1 INFO (from ropp_pp_compare): 5 elements of ropp_pp_test_2m.nc and ../data/ropp_pp_test_2m_reference.nc differ significantly **************************** ********** *FAIL* ********** **************************** ... examine t_pp_occ_1.log for details Testing ROPP PP occ tool on GNOS data... Running t_pp_occ_gnos_1 (PP occ; GNOS data) ... ---------------------------------------------------------------------- ROPP PP File Comparison Tool ---------------------------------------------------------------------- INFO (from ropp_pp_compare): Comparing ropp_pp_test_gnos.nc and ../data/ropp_pp_test_gnos_reference.nc: the results of running test t_pp_occ_gnos_1 (PP occ; GNOS data) ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%bangle values ARE significantly different: |diff| = 2.93163E-05 > 1.00000E-05 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%bangle_opt values ARE significantly different: |diff| = 2.93162E-05 > 1.00000E-06 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%bangle_L1 values ARE significantly different: |diff| = 2.93163E-05 > 1.00000E-06 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%bangle_L2 values ARE significantly different: |diff| = 2.93163E-05 > 1.00000E-06 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%bangle_L2_sigma values ARE significantly different: |diff| = 4.05745E-04 > 1.00000E-06 ERROR (from ropp_io_fields_compare): Profile 1 Lev2a%refrac values ARE significantly different: |diff| = 8.86282E-02 > 1.00000E-06 ERROR (from ropp_io_fields_compare): Profile 1 Lev2a%dry_temp values ARE significantly different: |diff| = 1.65591E+00 > 1.00000E-04 INFO (from ropp_pp_compare): Differences occurred in profile 1 INFO (from ropp_pp_compare): 7 elements of ropp_pp_test_gnos.nc and ../data/ropp_pp_test_gnos_reference.nc differ significantly **************************** ********** *FAIL* ********** **************************** ... examine t_pp_occ_gnos_1.log for details Testing ROPP PP raw sampling tool... Running t_pp_rs_1 (PP raw sampling; default options) ... ---------------------------------------------------------------------- ROPP PP File Comparison Tool ---------------------------------------------------------------------- INFO (from ropp_pp_compare): Comparing ropp_pp_test_3m.nc and ../data/ropp_pp_test_3m_reference.nc: the results of running test t_pp_rs_1 (PP raw sampling; default options) ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%bangle values ARE significantly different: |diff| = 2.41278E-05 > 1.00000E-05 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%bangle_opt values ARE significantly different: |diff| = 6.62235E-06 > 1.00000E-06 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%bangle_L1 values ARE significantly different: |diff| = 4.96390E-06 > 1.00000E-06 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%bangle_L2 values ARE significantly different: |diff| = 1.56093E-05 > 1.00000E-06 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%bangle_L2_sigma values ARE significantly different: |diff| = 3.11543E-05 > 1.00000E-06 ERROR (from ropp_io_fields_compare): Profile 1 Lev2a%refrac values ARE significantly different: |diff| = 2.19414E-02 > 1.00000E-06 ERROR (from ropp_io_fields_compare): Profile 1 Lev2a%dry_temp values ARE significantly different: |diff| = 6.93000E-01 > 1.00000E-04 INFO (from ropp_pp_compare): Differences occurred in profile 1 INFO (from ropp_pp_compare): 7 elements of ropp_pp_test_3m.nc and ../data/ropp_pp_test_3m_reference.nc differ significantly **************************** ********** *FAIL* ********** **************************** ... examine t_pp_rs_1.log for details ************************** SUMMARY OF ROPP_PP TEST RESULTS *************************** -------------------------------------------------------------------------------------- | Test name | Description | Run? | PASS? | -------------------------------------------------------------------------------------- | t_pp_invert_1 | PP invert; default options | Run | PASS | | t_pp_occ_1 | PP occ; default options | Run | *FAIL* | | t_pp_occ_gnos_1 | PP occ; GNOS data | Run | *FAIL* | | t_pp_rs_1 | PP raw sampling; default optio | Run | *FAIL* | | t_pp_abel_1 | PP Abel/Inv; def opts | Run | PASS | | t_pp_spectra_1a | PP spectra; def opt (L1 dt) | Run | PASS | | t_pp_spectra_1b | PP spectra; def opt (L2 dt) | Run | PASS | | t_pp_spectra_1c | PP spectra; def opt (L1 ep) | Run | PASS | | t_pp_spectra_1d | PP spectra; def opt (L2 ep) | Run | PASS | | t_pp_wopt_1 | PP 1D WOPT; quick options | Run | PASS | | t_pp_wopt_2d_1 | PP 2D WOPT; quick options | Run | PASS | -------------------------------------------------------------------------------------- Similar changes to before, although delta Tdry a bit smaller.Update reference files and commit change at r6826.
ROPP PP user guide updated at r6827.
Closing ticket.