Opened 6 years ago

Closed 3 years ago

Last modified 3 years ago

#621 closed task (fixed)

Writing SO fitting regression factors to diagnostics [ 2d]

Reported by: Ian Culverwell Owned by: Ian Culverwell
Priority: normal Milestone: ROPP9.1 carry over
Component: ropp_pp Version: 11.0
Keywords: Cc:

Description

Change history (3)

comment:1 by Ian Culverwell, 3 years ago

Code changes seem unexceptional, and don't cause any test problems, so these changes have been committed to ROPP-11 at r6805 and r6806.

Note that

            diag%sq = 100.0_wp *   &
                      MAXVAL(SQRT(diag%err_neut(:))/out_ba%bangle_opt(imin:imax))

has been removed from ropp_pp_occ_tool.f90. diag%sq is calculated by ropp_pp_ionospheric_correction, which is called just before the calculation of diag%sq above. For the standard core test, the old code produces

    IC_badness_score = 12.92954 ;

whereas the new code (i.e. calculating diag%sq in ropp_pp_ionospheric_correction) produces

    IC_badness_score = 10.96914 ;

So about 20% different.

comment:2 by Ian Culverwell, 3 years ago

Resolution: fixed
Status: newclosed
Version: 9.010.0

ROPP-11 PP user guide updated at r6807. Closing ticket.

comment:3 by Ian Culverwell, 3 years ago

Version: 10.011.0
Note: See TracTickets for help on using tickets.