Opened 6 years ago
Closed 3 years ago
#635 closed task (fixed)
Changing filter width and other parameters [1 h]
Reported by: | Ian Culverwell | Owned by: | Ian Culverwell |
---|---|---|---|
Priority: | normal | Milestone: | ROPP9.1 carry over |
Component: | ropp_pp | Version: | 11.0 |
Keywords: | Cc: | Stig Syndergaard |
Description
https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/config/Makefile.am https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/config/champ_pp.cf https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/config/cosmic_pp.cf https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/config/default_pp.cf https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/config/grace_pp.cf https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/config/gras_pp.cf https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/config/grassaf_invert.cf https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/config/metop_pp.cf https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/config/romsaf_invert.cf https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/config/wopt_pp.cf
Original changesets:
Changing filter width and other parameters: https://trac.romsaf.org/ropp/changeset/5166
Change history (3)
comment:1 by , 3 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Version: | 9.0 → 11.0 |
comment:2 by , 3 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Reopening ticket as the last point above needs discussing.
comment:3 by , 3 years ago
Cc: | added |
---|---|
Resolution: | → fixed |
Status: | reopened → closed |
Stig confirms that DMI are using serial/parallel
, so we can close this ticket.
(My confusion arose because of a snafu in the set of revisions at the top of this ticket. The 'original changeset' r5166 says (e.g. for champ_pp.cf):
sf_method = regular # Search and fit method (convoluted or regular)
But the later (rev 5427) files, listed individually at the top of the ticket, say (e.g. for champ_pp.cf):
sf_method = serial # Search and fit method (parallel or serial)
So sometime between the two revisions DMI switched to the ROPP names.
Lots of these undo the changes implemented in r6820 (see #633)! Never mind.
Affects the occ, occ_gnos and rs tests:
Differences are smallish, except for 10 K diffs in Tdry, which is not unusual. Update reference files.
(test_pp_rs.sh passes the results of ropp_pp_grasrs2ropp through ropp_pp_occ_tool -c ../config/gras_pp.cf, and the latter has been updated to use
model_err = 0.5
instead of-0.5
. In fact this same change has also been applied to champ_pp.cf, default_pp.cf and grassaf_invert.cf.)Commit changes at r6822. Close ticket.
Note that, for some reason, DMI are using
sf_method = convoluted/regular
, whereas ROPP usessf_method = parallel/serial
respectively. I don't know where this difference crept in - I thought we discussed the names of these options when the new scheme was introduced. It will need to be resolved at some point.