Opened 6 years ago

Closed 3 years ago

#635 closed task (fixed)

Changing filter width and other parameters [1 h]

Reported by: Ian Culverwell Owned by: Ian Culverwell
Priority: normal Milestone: ROPP9.1 carry over
Component: ropp_pp Version: 11.0
Keywords: Cc: Stig Syndergaard

Description

Change history (3)

comment:1 by Ian Culverwell, 3 years ago

Resolution: fixed
Status: newclosed
Version: 9.011.0

Lots of these undo the changes implemented in r6820 (see #633)! Never mind.

Affects the occ, occ_gnos and rs tests:

************************** SUMMARY OF ROPP_PP TEST RESULTS ***************************
--------------------------------------------------------------------------------------
|                   Test name    |              Description       |    Run? |  PASS? |
--------------------------------------------------------------------------------------
|                  t_pp_invert_1 |     PP invert; default options |     Run |  PASS  |
|                     t_pp_occ_1 |        PP occ; default options |     Run | *FAIL* |
|                t_pp_occ_gnos_1 |              PP occ; GNOS data |     Run | *FAIL* |
|                      t_pp_rs_1 | PP raw sampling; default optio |     Run | *FAIL* |
|                    t_pp_abel_1 |          PP Abel/Inv; def opts |     Run |  PASS  |
|                t_pp_spectra_1a |    PP spectra; def opt (L1 dt) |     Run |  PASS  |
|                t_pp_spectra_1b |    PP spectra; def opt (L2 dt) |     Run |  PASS  |
|                t_pp_spectra_1c |    PP spectra; def opt (L1 ep) |     Run |  PASS  |
|                t_pp_spectra_1d |    PP spectra; def opt (L2 ep) |     Run |  PASS  |
|                    t_pp_wopt_1 |      PP 1D WOPT; quick options |     Run |  PASS  |
|                 t_pp_wopt_2d_1 |      PP 2D WOPT; quick options |     Run |  PASS  |
--------------------------------------------------------------------------------------

Differences are smallish, except for 10 K diffs in Tdry, which is not unusual. Update reference files.

(test_pp_rs.sh passes the results of ropp_pp_grasrs2ropp through ropp_pp_occ_tool -c ../config/gras_pp.cf, and the latter has been updated to use model_err = 0.5 instead of -0.5. In fact this same change has also been applied to champ_pp.cf, default_pp.cf and grassaf_invert.cf.)

Commit changes at r6822. Close ticket.

Note that, for some reason, DMI are using sf_method = convoluted/regular, whereas ROPP uses sf_method = parallel/serial respectively. I don't know where this difference crept in - I thought we discussed the names of these options when the new scheme was introduced. It will need to be resolved at some point.

comment:2 by Ian Culverwell, 3 years ago

Resolution: fixed
Status: closedreopened

Reopening ticket as the last point above needs discussing.

comment:3 by Ian Culverwell, 3 years ago

Cc: Stig Syndergaard added
Resolution: fixed
Status: reopenedclosed

Stig confirms that DMI are using serial/parallel, so we can close this ticket.

(My confusion arose because of a snafu in the set of revisions at the top of this ticket. The 'original changeset' r5166 says (e.g. for champ_pp.cf):

sf_method = regular     # Search and fit method (convoluted or regular)

But the later (rev 5427) files, listed individually at the top of the ticket, say (e.g. for champ_pp.cf):

sf_method = serial      # Search and fit method (parallel or serial)

So sometime between the two revisions DMI switched to the ROPP names.

Note: See TracTickets for help on using tickets.