#13 closed defect (fixed)
Optional arguments in some datetime routines
Reported by: | frcm | Owned by: | frcm |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | ropp_utils | Version: | 0.7 |
Keywords: | Cc: |
Description
Some of the routines in the datetime section have an optional ierr argument; in the code, this used without checking if it has actually been given to the routine (e.g., in ymd2jd). This should cause warnings from the compiler, and may give segfaults at runtime if not detected at compile time (and if an error condition occures).
Change history (6)
comment:1 by , 19 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:2 by , 19 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Still not fully fixed:
Lowering Error: array upper bound is not a symbol for datatype 78 PGF90-F-0000-Internal compiler error. Errors in Lowering 1 (../datetime/js2ymds.f90: 110) PGF90/any Linux/x86 6.0-4: compilation aborted make[1]: * datetime/js2ymds.o Error 2 make[1]: Leaving directory `/net/home/h02/frae/temp/ropp_tools/build' make: * [all-recursive] Error 1
comment:3 by , 19 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Ooops - indeed. There is at least one more routine (jd2ymd()) which had optional arguments that were not properly treated. This should now be fixed...
comment:4 by , 19 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Problem still present, this is the g95 output. ifc gives similar results, thus could not confirm yet working Revision [646].
echo |
'./'`../datetime/js2ymds.f90
In file ../datetime/js2ymds.f90:123
- integer, dimension(:)
- err 1
Error: Array at (1) cannot have a deferred shape make[1]: * datetime/js2ymds.o Error 1 make[1]: Leaving directory `/net/home/h02/frae/temp/ropp_tools/build' make: * [all-recursive] Error 1
comment:5 by , 19 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Left over old file was used in compilation. Now closed.
Fixed by changeset [644].