Opened 13 years ago
Closed 11 years ago
#260 closed defect (fixed)
Bug in reading L2-phases from GRAS raw sampling files
| Reported by: | kmk | Owned by: | Ian Culverwell |
|---|---|---|---|
| Priority: | normal | Milestone: | 7.0 |
| Component: | ropp_pp | Version: | 5.0 |
| Keywords: | Cc: |
Description
There's a bug in ropp_pp_grasrs2ropp which causes an erroneous interpretation of the L2 phase data.
Lines 319 - 320:
319 cl_exphase_p2(:) = cl_exphase_l2_nco(:) - & 320 (c_light/(2.0_wp*pi*f_L2))*cl_phase_l2_iq(:)
Minus should be a plus. Like this:
319 cl_exphase_p2(:) = cl_exphase_l2_nco(:) + & 320 (c_light/(2.0_wp*pi*f_L2))*cl_phase_l2_iq(:)
Attachments (1)
Change history (6)
comment:1 by , 12 years ago
comment:2 by , 12 years ago
| Milestone: | 7.0 → 6.1 |
|---|---|
| Owner: | set to |
| Status: | new → assigned |
Safe to include in ROPP6.1? Let's try it.
comment:3 by , 12 years ago
| Milestone: | 6.1 → 7.0 |
|---|
No - it'll mess up the test folder (IT-PP-05). Send it back to 7.0.
comment:5 by , 11 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
For the ropp_pp_grasrs_test.nc example GRAS RS data provided with the ROPP test data sampling, this changes the L2 excess phase by ~1m where it is > 500m. It makes a large fractional difference where the excess phase is small, however: