Pointer allocation warning in ropp_1dvar

[Ian Culverwell]

ropp_1dvar says

WARNING (from ropp_1dvar_refrac): Pointer to full matrix already associated - deallocating.

Why? It doesn't (apparently ...) cause any problems, but we should probably get to the bottom of this.

[Ian Culverwell]

The problem appears to be that pointer array covar is allocated before the call to matrix_pp2full_alloc for ropp_1dvar_covar_bg.f90.

! Select covariance matrix with same dimensions as variable sigma ALLOCATE(covar(SIZE(sigma,1),SIZE(sigma,1))) CALL matrix_pp2full_alloc(corcov(idx_lat) % corr, covar)

This means covar is ASSOCIATED. But these routines check (array=covar)

if (associated(array)) then

call message(msg_warn, &

'Pointer to full matrix already associated - deallocating.\n')

deallocate(array)

endif

and hence we get the warning. Solution? Don't allocate covar in the calling routine ropp_ropp_1dvar_covar_bg.f90 (but keep deallocating it afterwards). See r3787 for details.

[Ian Culverwell]

Seems to work OK: warning messages gone, and nc files bit compatible.

Closing ticket - will be incorporated in ROPP7.0.