DMI wishlist for ROPP8.0

[Ian Culverwell]

Stig Syndergaard (DMI) writes:

Hi Ian,

I've compiled a list of ROPP changes that we have made in our dmi_trunk over the
past year, and which we think would be useful to get into ROPP 8.0. There are
not that many and they are all fairly minor. Some of them you already know.

Our dmi_trunk is still only at 6.1, so the changes below are on top of the ROPP
6.1 distribution (soon we will be merging everything into 7.1 and I might bother
you again with some more issues when that time comes). Some of the changes dates
back even further than 6.1, but the links I've given below are pointing at the
changesets when they were merged into 6.1 or when they were done later.

We could discuss some or all at the ROPP GG telecon next week, or just over
email later on if you have questions when/if you implement them in 8.0. But at
least I wanted you to have the list before the GG meeting.

I've added a few lines of comments to each changeset (below the link), and
reference to tickets in those cases I could find any.


Here is the list:

https://trac.romsaf.org/ropp/changeset/3645/ropp_src/branches/dev/Share/dmi_trunk_6.1/ropp_pp/preprocess/ropp_pp_preprocess_grasrs.f90

A change in the gap parameter. I think Kjartan was involved, but somehow  it
never made it to the official ROPP.



https://trac.romsaf.org/ropp/changeset/3645/ropp_src/branches/dev/Share/dmi_trunk_6.1/ropp_fm/tools/ropp_fm_bg2ro_1d.f90

Also an old issue that dates back to Kjartan, 
https://trac.romsaf.org/ropp/ticket/264 . It's about being able to  provide an
atm file on the command line so that the output background  data comes out on
the same levels as the observation. Personally, I find  it very useful.



https://trac.romsaf.org/ropp/changeset/3645/ropp_src/branches/dev/Share/dmi_trunk_6.1/ropp_utils/coordinates/occ_point.f90
https://trac.romsaf.org/ropp/changeset/3645/ropp_src/branches/dev/Share/dmi_trunk_6.1/ropp_utils/coordinates/tangent_point.f90

The azimuth issue. You already have it on your list for 8.0. 
https://trac.romsaf.org/ropp/ticket/325 .



https://trac.romsaf.org/ropp/changeset/3815/ropp_src/branches/dev/Share/dmi_trunk_6.1/ropp_io/tools/ucar2ropp.f90
https://trac.romsaf.org/ropp/changeset/3965/ropp_src/branches/dev/Share/dmi_trunk_6.1/ropp_io/tools/eum2ropp.f90
https://trac.romsaf.org/ropp/changeset/4002/ropp_src/branches/dev/Share/dmi_trunk_6.1/ropp_fm/tools/ropp_fm_bg2ro_1d.f90

Range check issues. Generally we are trying to avoid the range-check in  our
operations. The changes are toward making all range-checks optional.  Something
we could perhaps discuss at the PT14.



https://trac.romsaf.org/ropp/changeset/3871/ropp_src/branches/dev/Share/dmi_trunk_6.1/ropp_pp

A change to make it possible to choose a static model error in the  stat.opt.
part of ropp_pp, instead of a dynamical estimation. This is  how it is in the
OCC code and we've used it for ROtrends data sets in  the past. Don't know why
it was never implemented in ROPP by Huw. 
https://trac.romsaf.org/ropp/ticket/343



https://trac.romsaf.org/ropp/changeset/3646/ropp_src/branches/dev/Share/dmi_trunk_6.1/ropp_svn_install.sh
https://trac.romsaf.org/ropp/changeset/3903/ropp_src/branches/dev/Share/dmi_trunk_6.1/ropp_svn_install.sh

I noticed that MetOffice didn't maintain the ropp_svn_install.sh script  in 6.1,
so I did it. This is the script we use to install ROPP from svn,  and it makes
life easier for the team here (at least that's the intent).  But since we are
probably the only ones using it, perhaps it should be  left out of the official
ROPP distribution. We would just keep having it  in our dmi_trunk. Would be fine
with me if you choose to skip it for  ROPP 8.0. Just let me know.



https://trac.romsaf.org/ropp/changeset/4077/ropp_src/branches/dev/Share/dmi_trunk_6.1

A changeset regarding the interpolation from GRIB files. You already  have it on
your list for 8.0. https://trac.romsaf.org/ropp/ticket/357



https://trac.romsaf.org/ropp/changeset/4101/ropp_src/branches/dev/Share/dmi_trunk_6.1

A changeset related to the wrong interpretation of verification time. 
https://trac.romsaf.org/ropp/ticket/346 and 
https://trac.romsaf.org/ropp/ticket/253 . The problem is our fault, we 
interpreted verification time in the wrong way long time ago, and now it  leaked
into ROPP. Joe fixed this in our dmi_trunk now, and the idea is  that in some
future upgrade of our processing system we will start using  this in operations
and get the right verification time in our bgr files  as well.


Talk to you next week at the ROPP GG meeting.
Cheers,
-Stig

[Ian Culverwell]

Last part has been fixed by reading

CALL grib_get(igrib, 'validityDate',  date) 
CALL grib_get(igrib, 'validityTime',  time) 

from the GRIB file instead of

CALL grib_get(igrib, 'dataDate',  date) 
CALL grib_get(igrib, 'dataTime',  time) 

See r4122 - r4119.

[Ian Culverwell]

Penultimate part has been included in ROPP8.0.

[Ian Culverwell]

Change in gap parameter done at r4194.

[Ian Culverwell]

Use of file specifying output levels done at r4195.

[Ian Culverwell]

Static model in stat opt doen st r4196.

[Ian Culverwell]

Azimuth corrected at r4201.

[Ian Culverwell]

Range-checking made optional in ucar2ropp at r4198.

Range-checking made optional in eum2ropp at r4199.

Range-checking made optional in -l option of ropp_fm_bg2ro_1d at r4200.

[Ian Culverwell]

ropp_svn_install updated to unpack grib tarballs (if necessary) at r4201.

[Ian Culverwell]

Typo: ropp_svn_install updated to unpack grib tarballs (if necessary) at r4202.

[Ian Culverwell]

This completes DMI's wishlist, so close the ticket.

[Ian Culverwell]

Afterword: the change in the gap parameter does have a big impact on profiles 1 and 4 of the new (2012) IT-PP-05.nc, so we'll need to amend the reference data in the test folder.