Incorrect RoC in output files

[Ian Culverwell]

ROPP8.0 beta reviewer Sean Healy (ECMWF) reports:

In, ropp_fm/tests

test_fm_iono.sh

-> pass

but there is a warning in the LOG files

WARNING (from set_obs_levels_bangle):  RoC missing from data structure ... setting equal to effective radius


t_iono

-> pass, but RoC missing when output?

RoC, und, lat =    -9.99990E+07    1.29449E+01   -3.65360E+01


t_iono_ad

-> pass. RoC set to a default value?

RoC, und, lat =     6.37100E+06    0.00000E+00   -3.65360E+01


t_iono_tl

-> pass. RoC set to a default value?

RoC, und, lat =     6.37100E+06    0.00000E+00   -3.65360E+01

Needs looking at.

[Ian Culverwell]

Perhaps this bird might be killed with the same stone as will be slung at the bottom bit of #384?

[Ian Culverwell]

The first bit is the issue noted in #403, and which we decided to keep.

[Ian Culverwell]

The RoC and undulation were being defaulted in t_iono_ad.f90 and t_iono_tl.f90, but this was evidently just a first guess to get it working. Replaced

obs_bangle%r_curve      = 6.371E6_wp

by the more general

    IF ( ro_data%GEOref%roc > ropp_MDTV ) THEN
      obs_bangle%r_curve      = ro_data%GEOref%roc
    ELSE
      obs_bangle%r_curve      = 6.371E6_wp
    ENDIF

(and similarly for undulation) in the iono testing tools.

Note that we would still have got RoC = 6.371E6 for these cases, because it was ropp_MDFV in the test input file ropp_fm/data/bgr20090401_000329_M02_2030337800_N0007_YYYY.nc, so copy the valid RoC of 6350031.60637 m from the reference file ropp_fm/data/bgr20090401_000329_M02_2030337800_N0007_YYYY_iono_ref.nc to this file. We then get:

*** Results log of t_iono_1 (FM IONO) ***
./t_iono
Ne_max, H_peak, H_width =     3.00000E+11    3.00000E+05    7.50000E+04
RoC, und, lat =     6.35003E+06    1.29449E+01   -3.65360E+01

    ii      impact   bangle_L1(test)    bangle_L1(ref)   bangle_L2(test)    bangle_L2(ref)
     1     2365.81    0.28312904E-01    0.28312904E-01    0.28322297E-01    0.28322297E-01
    11     3764.98    0.24506589E-01    0.24506589E-01    0.24516059E-01    0.24516059E-01
    21     5409.42    0.11645305E-01    0.11645305E-01    0.11654867E-01    0.11654867E-01
    31     7178.12    0.11537644E-01    0.11537644E-01    0.11547307E-01    0.11547307E-01
    41     8972.60    0.86063310E-02    0.86063310E-02    0.86160992E-02    0.86160992E-02
    51    10824.44    0.68233446E-02    0.68233446E-02    0.68332236E-02    0.68332236E-02
    61    12702.58    0.56243477E-02    0.56243477E-02    0.56343416E-02    0.56343416E-02
    71    14598.90    0.42547598E-02    0.42547598E-02    0.42648727E-02    0.42648727E-02
    81    16523.92    0.33219036E-02    0.33219036E-02    0.33321400E-02    0.33321400E-02
    91    18463.34    0.24479817E-02    0.24479817E-02    0.24583458E-02    0.24583458E-02
   101    20422.41    0.16899809E-02    0.16899809E-02    0.17004771E-02    0.17004771E-02
   111    22400.60    0.11921099E-02    0.11921099E-02    0.12027430E-02    0.12027430E-02
   121    24390.83    0.84512897E-03    0.84512897E-03    0.85590349E-03    0.85590349E-03
   131    26390.37    0.61557073E-03    0.61557073E-03    0.62649114E-03    0.62649114E-03
   141    28396.00    0.44076546E-03    0.44076546E-03    0.45183620E-03    0.45183620E-03
   151    30407.02    0.32362821E-03    0.32362821E-03    0.33485386E-03    0.33485386E-03
   161    32421.82    0.24237560E-03    0.24237560E-03    0.25376081E-03    0.25376081E-03
   171    34439.65    0.18108515E-03    0.18108515E-03    0.19263471E-03    0.19263471E-03
   181    36460.11    0.13572330E-03    0.13572330E-03    0.14744216E-03    0.14744216E-03
   191    38482.89    0.10409341E-03    0.10409341E-03    0.11598673E-03    0.11598673E-03
   201    40507.67    0.82296391E-04    0.82296391E-04    0.94369473E-04    0.94369473E-04
   211    42534.18    0.66367951E-04    0.66367951E-04    0.78626329E-04    0.78626329E-04
   221    44562.34    0.53847123E-04    0.53847123E-04    0.66296544E-04    0.66296544E-04
   231    46592.07    0.45112649E-04    0.45112649E-04    0.57759096E-04    0.57759096E-04
   241    48623.30    0.39406818E-04    0.39406818E-04    0.52256517E-04    0.52256517E-04
   251    50655.94    0.35230215E-04    0.35230215E-04    0.48289641E-04    0.48289641E-04
   261    52689.96    0.32089115E-04    0.32089115E-04    0.45365016E-04    0.45365016E-04
   271    54725.35    0.29725204E-04    0.29725204E-04    0.43224602E-04    0.43224602E-04
   281    56762.09    0.28120508E-04    0.28120508E-04    0.41850718E-04    0.41850718E-04
   291    58800.17    0.26963013E-04    0.26963013E-04    0.40931650E-04    0.40931650E-04
 Comparing against bending angles in ../data/bgr20090401_000329_M02_2030337800_N
 0007_YYYY_iono_ref.nc
****************************
**********  PASS  **********
****************************

*** Results log of t_iono_tl_1 (FM_TL IONO) ***
./t_iono_tl
Ne_max, H_peak, H_width =     3.00000E+11    3.00000E+05    7.50000E+04
RoC, und, lat =     6.35003E+06    1.29449E+01   -3.65360E+01

    |dx|/|dx|_init    |dy=Kdx|    (Kdx|H(x+dx)-H(x))/|.||.|   |H(x+dx)-H(x)-Kdx|/|H(x+dx)-H(x)|
    1.0000000000E+00    3.0402137299E-03   -9.9176755758E-01    2.9294560229E+01
    1.0000000000E-01    1.0735125085E-03   -9.9697502043E-01    9.0126511363E+00
    1.0000000000E-02    7.9490714808E-04    9.7527854993E-01    2.4560144272E-01
    1.0000000000E-03    9.3864010470E-05    9.9999805741E-01    8.3315521206E-02
    1.0000000000E-04    8.6807772836E-06    9.9999993471E-01    8.7863610557E-03
    1.0000000000E-05    8.6121593486E-07    9.9999999928E-01    8.8218798585E-04
    1.0000000000E-06    8.6053275443E-08    9.9999999999E-01    8.8253272338E-05
    1.0000000000E-07    8.6046446733E-09    1.0000000000E+00    8.8257196731E-06
    1.0000000000E-08    8.6045763880E-10    1.0000000000E+00    8.8249087300E-07
    1.0000000000E-09    8.6045694862E-11    1.0000000000E+00    1.2441719449E-07
    1.0000000000E-10    8.6045688317E-12    1.0000000000E+00    7.9425641862E-07
    1.0000000000E-11    8.6045612046E-13    9.9999999997E-01    7.6992770969E-06
    1.0000000000E-12    8.6045454125E-14    9.9999999596E-01    8.9911954737E-05
    1.0000000000E-13    8.6054424252E-15    9.9999957831E-01    9.2390587184E-04
    1.0000000000E-14    8.6046718036E-16    9.9995429958E-01    9.5603286279E-03
****************************
**********  PASS  **********
****************************

and

*** Results log of t_iono_ad_1 (FM_AD IONO) ***
./t_iono_ad
Ne_max, H_peak, H_width =     3.00000E+11    3.00000E+05    7.50000E+04
RoC, und, lat =     6.35003E+06    1.29449E+01   -3.65360E+01

    |dx|/|dx|_init     norm1=(Kdx|Kdx)_y  norm2=(K^TKdx|dx)_x  (norm1-norm2)/norm2
    1.0000000000E+00    1.9403327627E-06    1.9403327627E-06   -4.3654004279E-16
    1.0000000000E-01    1.7655001277E-08    1.7655001277E-08    1.8740992415E-16
    1.0000000000E-02    1.7495993808E-10    1.7495993808E-10    0.0000000000E+00
    1.0000000000E-03    1.7480235624E-12    1.7480235624E-12   -2.3105911852E-16
    1.0000000000E-04    1.7478661217E-14    1.7478661217E-14   -1.8053119639E-16
    1.0000000000E-05    1.7478503791E-16    1.7478503791E-16    4.2312380253E-16
    1.0000000000E-06    1.7478488048E-18    1.7478488048E-18    4.4075435795E-16
    1.0000000000E-07    1.7478486474E-20    1.7478486474E-20    5.1650905974E-16
    1.0000000000E-08    1.7478486316E-22    1.7478486316E-22   -6.7253784426E-16
    1.0000000000E-09    1.7478486301E-24    1.7478486301E-24   -2.1016807652E-16
****************************
**********  PASS  **********
****************************

All looking good, so commit changes at r4774.

[Ian Culverwell]

Closing ticket as 'fixed'.