Fix bug in OmA and OmB diagnostics

[Ian Culverwell]

One can sometimes find (eg attached)

*** max(omb), min(omb) =   9.99990e+07 -9.99990e+07
*** max(oma), min(oma) =   9.99990e+07 -9.99990e+07

when examining the diagnostic output variables OmB and OmA from ropp_1dvar_{bangle/refrac}. The -ropp_MDFV values presumably come from unmasked missing A (or B) values being used in the differencing.

This can probably (needs checking) be cured by replacing

  WHERE (obs % bangle > ropp_MDTV)
     diag % OmA = (obs % bangle - diag % res_bangle % bangle)
  ELSEWHERE
     diag % OmA = ropp_MDFV
  END WHERE

with

  WHERE ( (obs % bangle > ropp_MDTV) .AND. &
          (diag % res_bangle % bangle > ropp_MDTV) ) 
     diag % OmA = (obs % bangle - diag % res_bangle % bangle)
  ELSEWHERE
     diag % OmA = ropp_MDFV
  END WHERE

in ropp_1dvar_diagnostics.f90. Similarly for OmB in ropp_qc_omb.f90.

[Ian Culverwell]

atm20120612_neut.nc

[Ian Culverwell]

Yes, that seems to work. Changes

ncks -Q -H  -ddim_unlim,2 -ddim_lev1b,0 -vOmA,OmB IT-1DVAR-04_y_cntl.nc

OmA[600]=9.9999e+07 

OmB[600]=9.9999e+07

ncmax OmA IT-1DVAR-04_y_cntl.nc
9.9999e+07

ncmax OmB IT-1DVAR-04_y_cntl.nc
9.9999e+07 

to

ncks -H -Q -ddim_unlim,2 -ddim_lev1b,0 -vOmA,OmB IT-1DVAR-04_y_test1.nc

OmA[600]=-9.9999e+07 

OmB[600]=-9.9999e+07 

ncmax OmA IT-1DVAR-04_y_test1.nc
0.00444357 

ncmax OmB IT-1DVAR-04_y_test1.nc
0.00522239 

Code changes committed at r4772.

[Ian Culverwell]

test1.sh

[Ian Culverwell]

($ROPP_ROOT/Work/ROPP9.0/ropp_1dvar/OmA/test1.sh test script attached for reference.)

[Ian Culverwell]

Closing ticket.