Opened 6 years ago
Closed 5 years ago
#547 closed task (fixed)
Add azimuth, radius of curvature, and center of curvature [1 d]
Reported by: | Ian Culverwell | Owned by: | Ian Culverwell |
---|---|---|---|
Priority: | normal | Milestone: | ROPP9.1 carry over |
Component: | ropp_fm | Version: | 9.0 |
Keywords: | Cc: |
Description
https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/build/Makefile.am https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/common/ropp_fm.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/refrac_1d/Makefile.am https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/refrac_1d/ropp_fm_tdry.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/refrac_1d/ropp_fm_tdry_1d.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/tools/ropp_fm_bg2ro_1d.f90
Original changesets:
Add azimuth, radius of curvature, and center of curvature: https://trac.romsaf.org/ropp/changeset/4873/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_fm/tools/ropp_fm_bg2ro_1d.f90
Change history (3)
comment:1 by , 6 years ago
Component: | ROPP(all) → ropp_fm |
---|
comment:2 by , 5 years ago
comment:3 by , 5 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
It's not actually that difficult. We just transplant the change detailed in r4873 into the development branch. Not taking ro_data%dtocc
info from the levels file seems sensible, as does taking the roc, undulation and radius of curvature from it. It works out OK in practice:
In SUBROUTINE set_obs_levels_bangle_file: before: obs_bangle%r_curve = 0.000000000000000E+000 after: obs_bangle%r_curve = 6398739.32339869 before: obs_bangle%undulation = 0.000000000000000E+000 after: obs_bangle%undulation = -5.89915609359741 before: obs_bangle%azimuth = 0.000000000000000E+000 after: obs_bangle%azimuth = -99999000.0000000
The correct, non-default values have been transplanted into obs_bangle.
This change doesn't require any change to the test files because we don't (yet) test the -l
option to ropp_fm_bg2ro_1d.
Change committed at r5929. Closing ticket.
This is going to be difficult. The dmi version of ropp_fm_bg2ri_1d.f90 is very far from the ROPP trunk. It doesn't, for example, contain any of the improvements to the interface that were introduced at ROPP9.0. So reconciling the two will be a job.