Don't return exit code 1 when using the --no-ranchk option [1 h]

[Ian Culverwell]

https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/build/Makefile.am https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/common/ropp_fm.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/refrac_1d/Makefile.am https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/refrac_1d/ropp_fm_tdry.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/refrac_1d/ropp_fm_tdry_1d.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/tools/ropp_fm_bg2ro_1d.f90

Original changesets:

Don't return exit code 1 when using the --no-ranchk option: https://trac.romsaf.org/ropp/changeset/4884/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_fm/tools/ropp_fm_bg2ro_1d.f90

[Ian Culverwell]

Done at r5913.

Note that the ROPP trunk says

      CALL ropp_io_write(ro_data, ofile, append=.TRUE., ranchk=ranchk)

(where ranchk = .TRUE. unless --no-ranchk is specified) whereas the dmi_trunk says

      CALL ropp_io_write(ro_data, ofile, append=.TRUE., ranchk=.FALSE.)

i.e. range checking is never applied to output. We should discuss this with DMI, as range checking should usually be carried out. Perhaps we need two range checking switches, one for input and one for output?

Leaving ticket open as we need to discuss.

[Ian Culverwell]

In view of the fix described in #564 for return codes of 1, which are generated by WARNINGS, revert this change at r6237. This is a DMI problem.

(Note that ropp_fm_bg2ro_1d returns plenty of

WARNING (from set_obs_levels_bangle):  RoC missing from data structure ... setting equal to effective radius

messages, so it often/usually delivers a return code of 1 anyway.)