Opened 6 years ago

Closed 5 years ago

#549 closed task (fixed)

Do not extrapolate above model top [?]

Reported by: Ian Culverwell Owned by: Ian Culverwell
Priority: normal Milestone: ROPP9.1 carry over
Component: ropp_fm Version: 9.0
Keywords: Cc:

Description

https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/build/Makefile.am https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/common/ropp_fm.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/refrac_1d/Makefile.am https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/refrac_1d/ropp_fm_tdry.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/refrac_1d/ropp_fm_tdry_1d.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/tools/ropp_fm_bg2ro_1d.f90

Original changesets:

Do not extrapolate above model top: https://trac.romsaf.org/ropp/changeset/4924/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_fm/refrac_1d/ropp_fm_tdry_1d.f90

Change history (2)

comment:1 by Ian Culverwell, 6 years ago

Component: ROPP(all) → ropp_fm

comment:2 by Ian Culverwell, 5 years ago

Resolution: → fixed
Status: new → closed

OK. I updated ropp_fm/common/ropp_fm.f90 to reflect the changed argument list, for completeness.

What's the point of 

  !--- above model top
  DO i=1,SIZE(y%geop)
    IF (y%geop(i) > x%geop(x%n_lev)) THEN
      tdry(i) = gtop*Hscale/R_dry
    ENDIF
  ENDDO

when it's immediately followed by 

  DO i=1,SIZE(y%geop)
    IF ( (y%geop(i) < x%geop(1)) .OR. (y%geop(i) > x%geop(x%n_lev)) ) THEN
      tdry(i) = ropp_MDFV
    ENDIF
  ENDDO

?

No impact on testing - presumably the refractivity altitudes in our test files are always below the model top. Commit change at r5952, and close ticket.

Note: See TracTickets for help on using tickets.