Reference frame not read with ropp_io_read()

[marq]

Reference frame type is not read by ropp_io_read(); instead, ROprof structures always contain default values after reading data (if not changed manually before reading).

This bug was reported by Armin Löscher.

[Dave Offiler]

Is this reference_frame in the GEOType structure (currently defaulted to 'ECF' in GEORef)?

I would say this is not a true s/w bug, but an assumption that the reference frame is always ECF! Is this parameter actually writtento the netCDF file - then not read back; if so, then it clearly should be (even if it's aways written as 'ECF'!

The parameter isn't in the text format, I believe. As we agreed a while ago not to add new stuff to that flavour, then the ref frame parameter still needs to default to ECF (and the data truely be in ECF) for text files.

[Dave Offiler]

Not only the reference frame for CoC but also all combos of LEO & GNS vely & posn. have refrence frame types. By default, vely are set to ECI and the others ECF. They all appear in ropp_io_write_ncdf_def.f90 'ncdf_putatt()' calls so, as an attribute, I assume they are written to the (netDCF) file. But there's indeed no sign of being read back in.

So a user could define these parameters on non-default coordinate system, set the reference frame, write the file, but be told on read that the variables were (incorrectly) on the default ref frame.

Definite bug; all 5 ref_frames need to be read (from netCDF).

Checking a sample DMI nc file with ncdump, the r_roc ref frame is 'ECF', but the others are 'TOD' (whatevr that is). As I can't find any such string in our code, DMI must be explicitly setting these attibutes, but they would presumably be 'read' by the ropp tools as 'ECF'

General: there are many 'putatt' call in the write but very few corresponding 'getatt' call in the read. Is this a more widespread issue that all attitibutes written should be read back?

[Dave Offiler]

Too late for v1.1 (and not a show-stopper) but definitely needs review & fix for v1.2.

[Huw Lewis]

Updated ropp_io_read_ncdf_get with ncdf_getatt commands to read reference_frame attributes for r_gns, v_gns, r_leo, v_leo and r_coc (which were only defined as default and written out at v1.1). Note there are no conversion routines within ROPP to handle non-default reference frames (but this is maybe for future development based on user feedback). See change [1568]. Ticket closed.