Opened 6 years ago
Closed 3 years ago
#576 closed task (fixed)
Use 0.02 sec (cl and ol) or 0.001 sec (rs) assumed sampling times [0.5 d]
Reported by: | Ian Culverwell | Owned by: | Ian Culverwell |
---|---|---|---|
Priority: | normal | Milestone: | ROPP9.1 carry over |
Component: | ropp_io | Version: | 11.0 |
Keywords: | Cc: |
Description
https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/ropp/ropp_io.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/ropp/ropp_io_read.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/ropp/ropp_io_read_ncdf_get.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/tools/eum2bufr_ec.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/tools/eum2ropp.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/tools/ropp2bufr_ec.f90 (similar/consistent updates to ropp2bufr_mo.f90 has not been made since https://trac.romsaf.org/ropp/changeset/3430)
Original changesets:
Use 0.02 sec (cl and ol) or 0.001 sec (rs) assumed sampling times: https://trac.romsaf.org/ropp/changeset/5337/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/ropp/ropp_io_read_ncdf_get.f90
Change history (4)
comment:1 by , 5 years ago
comment:2 by , 5 years ago
The reasons for this change are clearly described in r5337. It causes no problems in the default eum2ropp test because bit 3 of the LCF flag is never activated by this check anyway. (It is set for the first three points, because snr_L1ca
is missing for these times, and
WHERE (ropp_io_isnan(data%Lev1a%snr_L1ca)) data%Lev1a%snr_L1ca = ropp_MDFV lcf = IBSET(lcf, 3) ENDWHERE
Hence:
prompt:> ncks -H -Q -ddim_lev1a,0,4 -vopen_loop_lcf,snr_L1ca eum_test_l.nc open_loop_lcf[0]=8 open_loop_lcf[1]=8 open_loop_lcf[2]=8 open_loop_lcf[3]=0 open_loop_lcf[4]=0 snr_L1ca[0]=-9.9999e+07 snr_L1ca[1]=-9.9999e+07 snr_L1ca[2]=-9.9999e+07 snr_L1ca[3]=780.569 snr_L1ca[4]=766.222
comment:3 by , 5 years ago
Code change committed at r5942. (This includes a local variable ts1_max
, to save computing 1.05*ts_{cl,olrs
} every time.) No documentation changes required. Closing ticket.
comment:4 by , 3 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Version: | 9.0 → 11.0 |
Really closing ticket.
Seems fairy nuff.