Opened 6 years ago
Closed 5 years ago
#579 closed task (fixed)
Remove samples with tracking state = 2 for setting, not rising [0.5 d]
Reported by: | Ian Culverwell | Owned by: | Ian Culverwell |
---|---|---|---|
Priority: | normal | Milestone: | ROPP9.1 carry over |
Component: | ropp_io | Version: | 9.0 |
Keywords: | Cc: |
Description
https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/ropp/ropp_io.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/ropp/ropp_io_read.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/ropp/ropp_io_read_ncdf_get.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/tools/eum2bufr_ec.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/tools/eum2ropp.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/tools/ropp2bufr_ec.f90 (similar/consistent updates to ropp2bufr_mo.f90 has not been made since https://trac.romsaf.org/ropp/changeset/3430)
Original changesets:
Remove samples with tracking state = 2 for setting, not rising: https://trac.romsaf.org/ropp/changeset/5349/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/ropp/ropp_io_read_ncdf_get.f90
Potentially quite a big impact. Previously, when calculating LCF we had been testing whether the profile was rising with statements like
But
data_cl%PCD
hadn't been calculated, but simply set to its default of2^16^-1
, which meant that all profiles were considered to be rising. Fortunately the ROPP test dataset data/eum_test.n4, is a rising one, so the change has no effect on that.The other aspect of the change is a change to the poilcy for handling RS data with a tracking state of 2: from
to
Happy to be led by Stig on this.
Once again, there's no raw sampling data in our test dataset, so no impact on the automatic tests.
Commit change at r5944, and close ticket.