Opened 6 years ago

Closed 5 years ago

#579 closed task (fixed)

Remove samples with tracking state = 2 for setting, not rising [0.5 d]

Reported by: Ian Culverwell Owned by: Ian Culverwell
Priority: normal Milestone: ROPP9.1 carry over
Component: ropp_io Version: 9.0
Keywords: Cc:

Description

Change history (1)

comment:1 by Ian Culverwell, 5 years ago

Resolution: fixed
Status: newclosed

Potentially quite a big impact. Previously, when calculating LCF we had been testing whether the profile was rising with statements like

        IF (BTEST(data_cl%PCD, PCD_rising)) THEN    ! Rising occultation

But data_cl%PCD hadn't been calculated, but simply set to its default of 2^16^-1, which meant that all profiles were considered to be rising. Fortunately the ROPP test dataset data/eum_test.n4, is a rising one, so the change has no effect on that.

The other aspect of the change is a change to the poilcy for handling RS data with a tracking state of 2: from

! For rising profiles remove all data with tracking state = 2 in the 
! beginning of the record as these are not valid. 

to

! For setting occultations remove all data with tracking state = 2 at the
! beginning of the record as these are not all valid and may in the processing
! result in cutting off the whole rs/ol section. For rising occultations it is
! better to include them, since the processing will find out where to cut off the
! bad ones at the bottom and thereby keep the good ones with tracking state = 2.

Happy to be led by Stig on this.

Once again, there's no raw sampling data in our test dataset, so no impact on the automatic tests.

Commit change at r5944, and close ticket.

Note: See TracTickets for help on using tickets.