Implemented option to get EUMETSATs navbit-corrected excess phase [2 d]

[Ian Culverwell]

https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/ropp/ropp_io.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/ropp/ropp_io_read.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/ropp/ropp_io_read_ncdf_get.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/tools/eum2bufr_ec.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/tools/eum2ropp.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/tools/ropp2bufr_ec.f90 (similar/consistent updates to ropp2bufr_mo.f90 has not been made since https://trac.romsaf.org/ropp/changeset/3430)

Original changesets:

Implemented option to get EUMETSATs navbit-corrected excess phase: https://trac.romsaf.org/ropp/changeset/5356

[Ian Culverwell]

There are two aspects to this ticket: the (convoluted) way of asking that the open loop data be taken from the file, rather than constructed from I & Q, as is presently done; and some (connected?) changes to the use of navbit corrections in some of the ropp_pp processing code.

[Ian Culverwell]

The first is tackled in r5963. Although, as discussed before, it cannot be tested directly with the standard EUM netCDF4 input file, the code can tested by temporarily transplanting it to the closed_loop section. We then find:

/data/users/idculv/ROPP/ropp_src/branches/dev/Share/ROPP100_prototype/ropp_io/tests
unix:> ../tools/eum2ropp ../data/eum_test.n4 -l cl+rs -c -o temp.nc

---------------------------------------------------------------------
                  EUMETSAT to ROPP netCDF Converter
---------------------------------------------------------------------

INFO (from eum2ropp):  Reading file ../data/eum_test.n4
 getdirect =  T
 data_cl%Lev1a%phase_L1 =   0.000000000000000E+000 -6.785616278648376E-004
 -1.664739102125168E-003 -2.410633489489555E-003 -2.951746806502342E-003
 -3.471540287137032E-003 -4.578532651066780E-003 -5.126187577843666E-003
 -5.161693319678307E-003 -5.939153954386711E-003 -6.768129765987396E-003

...

 -1.92392652295530       -1.92680374346673       -1.93036054819822     
 -1.93302997946739       -1.93635350093246     
INFO (from ropp_io_read_eumdata):  raw_sampling data requested but are not available in file
INFO (from eum2ropp):  Profile    1 : OC_20120909000057_META_G015_EUME
INFO (from eum2ropp):  Writing temp.nc

These match the values in the input file. There are also some changes to avoid trying to do this for eum2bufr and ropp2bufr.

[Ian Culverwell]

The second half of this ticket concerns changes to the pre-processing of GRAS data, including the (probably obsolete now) GRAS raw sampling code. The official pp module is now very distant from the DMI branch, but we can see where the changes go. This has been done at r5964. The changes amount to:

• only making the current correction for navigation bits in ropp_pp_preprocess.f90 and ropp_pp_spectra_tool if at least one of the points has the navigation bit of its LCF set; and
• doing some new discontinuity removal in ropp_pp_preprocess_grasrs.f90 if none of them have.

The test datasets have some LCFs set (or are made of COSMIC data, for which none of this applies), so the changes have no effect on the PP tests:

************************** SUMMARY OF ROPP_PP TEST RESULTS ***************************
--------------------------------------------------------------------------------------
|                   Test name    |              Description       |    Run? |  PASS? |
--------------------------------------------------------------------------------------
|                  t_pp_invert_1 |     PP invert; default options |     Run |  PASS  |
|                     t_pp_occ_1 |        PP occ; default options |     Run |  PASS  |
|                t_pp_occ_gnos_1 |              PP occ; GNOS data |     Run |  PASS  |
|                      t_pp_rs_1 | PP raw sampling; default optio |     Run |  PASS  |
|                    t_pp_abel_1 |          PP Abel/Inv; def opts |     Run |  PASS  |
|                t_pp_spectra_1a |    PP spectra; def opt (L1 dt) |     Run |  PASS  |
|                t_pp_spectra_1b |    PP spectra; def opt (L2 dt) |     Run |  PASS  |
|                t_pp_spectra_1c |    PP spectra; def opt (L1 ep) |     Run |  PASS  |
|                t_pp_spectra_1d |    PP spectra; def opt (L2 ep) |     Run |  PASS  |
|                    t_pp_wopt_1 |         PP WOPT; quick options |     Run |  PASS  |
--------------------------------------------------------------------------------------

Closing ticket.

[Ian Culverwell]

Testing with nagfor61 reveals a bug:

Error: ../ropp/ropp_io_read_ncdf_get.f90: Inconsistent INTERFACE block for procedure ROPP_IO_READ_NCDF_GET_EUMDATA from ROPP_IO
       Argument GETDIRECT (no. 7) should not have the OPTIONAL attribute
[NAG Fortran Compiler error termination, 2 errors, 6 warnings]

Fix this by correcting the interface block to ropp_io_read_ncdf_get_eumdata in ropp_io/ropp/ropp_io.f90 at r6132.