Opened 6 years ago
Closed 3 years ago
#603 closed task (fixed)
Make sure that the new rs/ol grid is strictly within the rs/ol data [1 h]
Reported by: | Ian Culverwell | Owned by: | Ian Culverwell |
---|---|---|---|
Priority: | normal | Milestone: | ROPP9.1 carry over |
Component: | ropp_pp | Version: | 11.0 |
Keywords: | Cc: |
Description
https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/build/Makefile.am https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/bangle/ropp_pp_bending_angle_go.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/preprocess/ropp_pp_cutoff.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/preprocess/ropp_pp_preproc.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/preprocess/ropp_pp_preprocess.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/preprocess/ropp_pp_preprocess_champ.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/preprocess/ropp_pp_preprocess_cosmic.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/preprocess/ropp_pp_preprocess_grasrs.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/tools/ropp_pp_spectra_tool.f90
Original changesets:
Make sure that the new rs/ol grid is strictly within the rs/ol data: https://trac.romsaf.org/ropp/changeset/5348/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_pp/preprocess/ropp_pp_preprocess_grasrs.f90
Change history (1)
comment:1 by , 3 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Version: | 9.0 → 11.0 |
By replacing
by
(for setting occs) we are fractionally reducing
dtime(i+1)-dtime(i)
by 2.0e-3 /n_rs secs. This means thatdtime(1)
is now greater thantmin
and thatdtime(n)
is now less thantmax
.Judging by the commit message, Stig found some cases where the earlier algorithm failed in the later interpolation.
Not surprisingly, this change causes the GRAS rs test to fail:
All diffs are concentrated at bottom. Small effects, as expected.
Update reference file and commit at r6842.
The UG doesn't go into enough detail to need updating.
Closing ticket.