Opened 6 years ago

Closed 3 years ago

#603 closed task (fixed)

Make sure that the new rs/ol grid is strictly within the rs/ol data [1 h]

Reported by: Ian Culverwell Owned by: Ian Culverwell
Priority: normal Milestone: ROPP9.1 carry over
Component: ropp_pp Version: 11.0
Keywords: Cc:

Description

Change history (1)

comment:1 by Ian Culverwell, 3 years ago

Resolution: fixed
Status: newclosed
Version: 9.011.0

By replacing

mg_data%dtime(i) = ((n-i)*t1 + (i-n1)*tmax)/(n-n1) 

by

mg_data%dtime(i) = ((n-i)*(t1+0.001_wp*ts) + (i-n1)*(tmax-0.001_wp*ts))/(n-n1) 

(for setting occs) we are fractionally reducing dtime(i+1)-dtime(i) by 2.0e-3 /n_rs secs. This means that dtime(1) is now greater than tmin and that dtime(n) is now less than tmax.

Judging by the commit message, Stig found some cases where the earlier algorithm failed in the later interpolation.

Not surprisingly, this change causes the GRAS rs test to fail:

Running t_pp_rs_1 (PP raw sampling; default options) ...

----------------------------------------------------------------------
                     ROPP PP File Comparison Tool
----------------------------------------------------------------------

INFO (from ropp_pp_compare):  Comparing ropp_pp_test_3m.nc and ../data/ropp_pp_test_3m_reference.nc:
   the results of running test t_pp_rs_1 (PP raw sampling; default options)
 
ERROR (from ropp_io_fields_compare):  Profile 1 GEOref%time_offset values values ARE significantly different: |diff| =      1.33514E-05 >  1.00000E-06
 
ERROR (from ropp_io_fields_compare):  Profile 1 GEOref%lon values values ARE significantly different: |diff| =              1.90735E-06 >  1.00000E-06
 
ERROR (from ropp_io_fields_compare):  Profile 1 Lev1b%lon_tp values ARE significantly different: |diff| =                   9.22680E-03 >  1.00000E-04
 
ERROR (from ropp_io_fields_compare):  Profile 1 Lev1b%bangle values ARE significantly different: |diff| =                   3.30661E-05 >  1.00000E-05
 
ERROR (from ropp_io_fields_compare):  Profile 1 Lev1b%bangle_opt values ARE significantly different: |diff| =               3.31431E-05 >  1.00000E-06
 
ERROR (from ropp_io_fields_compare):  Profile 1 Lev1b%bangle_L1 values ARE significantly different: |diff| =                3.31413E-05 >  1.00000E-06
 
ERROR (from ropp_io_fields_compare):  Profile 1 Lev1b%bangle_L1_sigma values ARE significantly different: |diff| =          2.66497E-04 >  1.00000E-06
 
ERROR (from ropp_io_fields_compare):  Profile 1 Lev1b%bangle_L2 values ARE significantly different: |diff| =                3.31900E-05 >  1.00000E-06
 
ERROR (from ropp_io_fields_compare):  Profile 1 Lev1b%bangle_L2_sigma values ARE significantly different: |diff| =          2.66497E-04 >  1.00000E-06
 
ERROR (from ropp_io_fields_compare):  Profile 1 Lev2a%refrac values ARE significantly different: |diff| =                   1.06766E-01 >  1.00000E-06
 
ERROR (from ropp_io_fields_compare):  Profile 1 Lev2a%dry_temp values ARE significantly different: |diff| =                 8.07153E-02 >  1.00000E-04
INFO (from ropp_pp_compare):  Differences occurred in profile 1
INFO (from ropp_pp_compare):  11 elements of ropp_pp_test_3m.nc and ../data/ropp_pp_test_3m_reference.nc differ significantly
****************************
********** *FAIL* **********
****************************
... examine t_pp_rs_1.log for details

All diffs are concentrated at bottom. Small effects, as expected.

Update reference file and commit at r6842.

The UG doesn't go into enough detail to need updating.

Closing ticket.

Note: See TracTickets for help on using tickets.