Opened 6 years ago
Closed 3 years ago
#604 closed task (fixed)
Avoid undefined ts for very gappy open loop data [1 h]
Reported by: | Ian Culverwell | Owned by: | Ian Culverwell |
---|---|---|---|
Priority: | normal | Milestone: | ROPP9.1 carry over |
Component: | ropp_pp | Version: | 11.0 |
Keywords: | Cc: |
Description
https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/build/Makefile.am https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/bangle/ropp_pp_bending_angle_go.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/preprocess/ropp_pp_cutoff.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/preprocess/ropp_pp_preproc.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/preprocess/ropp_pp_preprocess.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/preprocess/ropp_pp_preprocess_champ.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/preprocess/ropp_pp_preprocess_cosmic.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/preprocess/ropp_pp_preprocess_grasrs.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/tools/ropp_pp_spectra_tool.f90
Original changesets:
Avoid undefined ts for very gappy open loop data: https://trac.romsaf.org/ropp/changeset/5354/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_pp/preprocess/ropp_pp_preprocess_grasrs.f90
Change history (1)
comment:1 by , 3 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Version: | 9.0 → 11.0 |
A further complication to the already-quite-complicated-enough-thank-you #601.
Basically this amounts to setting
dn
to 1 (corresponding ton_rs
= 2) if the GRAS preprocessing code infers that it is trying to work with OL rather than RS data. I suppose this avoidsts
from being undefined for very gappy OL data because it is now comparing adjacent points in the OL tseries, not those separated bydn
points. Perhaps this makes it less likely that theMASK
condition inis never met - see comment in #600.
Checks out OK - the activating test on
ts
is not met in our test dataset.Commit change at r6843.
No documentation needs updating.
Closing ticket.