#638 closed task (fixed)
svn merge of cb_tp_bending [5 d]
Reported by: | Ian Culverwell | Owned by: | Ian Culverwell |
---|---|---|---|
Priority: | normal | Milestone: | ROPP9.1 carry over |
Component: | ropp_utils | Version: | 9.0 |
Keywords: | Cc: |
Description
https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_utils/build/Makefile.am https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_utils/coordinates/ecf2eci.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_utils/coordinates/eci2ecf.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_utils/coordinates/eci2eci.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_utils/coordinates/coordinates.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_utils/coordinates/occ_point.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_utils/coordinates/tangent_point.f90
Original changesets:
svn merge of cb_tp_bending: https://trac.romsaf.org/ropp/changeset/4668
Attachments (1)
Change history (11)
comment:1 by , 5 years ago
comment:2 by , 5 years ago
Also: where's a decent reference to the method? Code refers to Foelsche et al. AMT 2011, but I can't find anything relevant. Ask Stig.
comment:3 by , 5 years ago
Reference:
@Article{Foelsche2011a, Author = {Foelsche, U., Syndergaard, S., Fritzer, J. and Kirchengast, G.}, Title = {Errors in {GNSS} radio occultation data: relevance of the measurement geometry and obliquity of profiles}, Journal = {Atmospheric Measurement Techniques}, Volume = {4}, doi = {doi:10.5194/amt-4-189-2011}, Pages = {189--199}, year = 2011 }
added to ropp_templates/bibtex/bib/meteorology.bib, and included in header of ropp_utils/coordinates/tangent_point.f90.
comment:4 by , 5 years ago
The difference in the lons, lats and azis brought about by the use of bangle%impact_L1
rather than bangle%impact
as the independent variable in the call to ropp_pp_interpol
is shown in It's around a degree in all the variables at the bottom of the profile - not insignificant. Expect effects on the test folder.
comment:5 by , 5 years ago
(Likewise for the differences in the results of test_pp_occ_gnos.sh and test_pp_rs.sh.)
comment:6 by , 5 years ago
Note that these changes are not relevant to ropp_pp_invert_tool, though the change effected at r5595 - namely the bug-fix
WHERE ( out_ba%impact_L1 > config%Pmax - 5000.0_wp )
to
WHERE ( out_ba%impact_L1 > out_ba%impact_L1(imax) )
- probably should. When DMI talk about 'occ' now, they mean 'occ'+'invert'. This inconsistency should really be addressed now, though it could involve a lot of work in documentation, test suites (auto and test folder), etc. Open new ticket #654 on it for ROPP10.0.
comment:8 by , 5 years ago
comment:9 by , 5 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Closing ticket. Expect this work to be re-examined when the occ and invert unification is addressed in #654.
comment:10 by , 4 years ago
Stig pointed out a problem with the condition
IF ( ANY(ro_data%georef%r_coc < ropp_MDTV) ) THEN
in ropp_pp_occ_tool.f90. Valid components of r_coc
can easily be > 10 km (~ropp_MDTV), and therefore fail the condition. He proposes the replacement
IF ( ANY(ro_data%georef%r_coc < 10.0_wp*ropp_MDTV) ) THEN
This tests out OK, so commit change to trunk at r6545.
Equivalent changes have been introduced at r5901.
Notes:
ropp_pp_interpolate_latlonaz.f90
in the build (that's to be done in #613), so I've just usedgo_l1_ip = bangle%impact_L1
rather thanbangle%impact
in the four calls toropp_pp_interpol
. Note that this is enough to break themake test
tests:Likewise for test_pp_occ_gnos.sh and test_pp_rs.sh, which use ropp_pp_occ_tool, so we end up with a final test table looking like
This is probably OK - the differences are rather small. But it beard recording. I will need to update the test reference file. This may also affect the test folder. UG needs updating too.