Opened 7 years ago
Closed 6 years ago
#639 closed task (fixed)
Fixing problem with occ_point.f90 and tangent_point.f90 [2 d]
| Reported by: | Ian Culverwell | Owned by: | Ian Culverwell |
|---|---|---|---|
| Priority: | normal | Milestone: | ROPP9.1 carry over |
| Component: | ropp_utils | Version: | 9.0 |
| Keywords: | Cc: |
Description
https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_utils/build/Makefile.am https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_utils/coordinates/ecf2eci.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_utils/coordinates/eci2ecf.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_utils/coordinates/eci2eci.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_utils/coordinates/coordinates.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_utils/coordinates/occ_point.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_utils/coordinates/tangent_point.f90
Original changesets:
Fixing problem with occ_point.f90 and tangent_point.f90: https://trac.romsaf.org/ropp/changeset/4674
Attachments (1)
Change history (5)
comment:1 by , 6 years ago
comment:3 by , 6 years ago
The smallness of the differences suggest that it's probably safe to just update the reference files with the latest ones. This is done at r5907, and gives a clean sweep of the make test tests:
************************** SUMMARY OF ROPP_PP TEST RESULTS *************************** -------------------------------------------------------------------------------------- | Test name | Description | Run? | PASS? | -------------------------------------------------------------------------------------- | t_pp_invert_1 | PP invert; default options | Run | PASS | | t_pp_occ_1 | PP occ; default options | Run | PASS | | t_pp_occ_gnos_1 | PP occ; GNOS data | Run | PASS | | t_pp_rs_1 | PP raw sampling; default optio | Run | PASS | | t_pp_abel_1 | PP Abel/Inv; def opts | Run | PASS | | t_pp_spectra_1a | PP spectra; def opt (L1 dt) | Run | PASS | | t_pp_spectra_1b | PP spectra; def opt (L2 dt) | Run | PASS | | t_pp_spectra_1c | PP spectra; def opt (L1 ep) | Run | PASS | | t_pp_spectra_1d | PP spectra; def opt (L2 ep) | Run | PASS | | t_pp_wopt_1 | PP WOPT; quick options | Run | PASS | --------------------------------------------------------------------------------------
comment:4 by , 6 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
As for #638, expect some effects in the test folder, but, for now, closing ticket.
This makes further changes to occ_point.f90 and tangent_point.f90, beyond those in #638. In particular, the referencing to
r_cocis now enforced, rather than optional. This makes small differences in a lot of the 'make tests':make test Testing ROPP PP invert tool... Running t_pp_invert_1 (PP invert; default options) ... ---------------------------------------------------------------------- ROPP PP File Comparison Tool ---------------------------------------------------------------------- INFO (from ropp_pp_compare): Comparing ropp_pp_test_1m.nc and ../data/ropp_pp_test_1m_reference.nc: the results of running test t_pp_invert_1 (PP invert; default options) **************************** ********** PASS ********** **************************** ... examine t_pp_invert_1.log for details Testing ROPP PP occ tool... Running t_pp_occ_1 (PP occ; default options) ... ---------------------------------------------------------------------- ROPP PP File Comparison Tool ---------------------------------------------------------------------- INFO (from ropp_pp_compare): Comparing ropp_pp_test_2m.nc and ../data/ropp_pp_test_2m_reference.nc: the results of running test t_pp_occ_1 (PP occ; default options) ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%lat_tp values ARE significantly different: |diff| = 1.56035E-02 > 1.00000E-04 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%lon_tp values ARE significantly different: |diff| = 1.96838E-03 > 1.00000E-04 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%bangle_L1_sigma values ARE significantly different: |diff| = 1.02372E-06 > 1.00000E-06 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%bangle_L2_sigma values ARE significantly different: |diff| = 1.02372E-06 > 1.00000E-06 ERROR (from ropp_io_fields_compare): Profile 1 Lev2a%refrac values ARE significantly different: |diff| = 7.50187E-04 > 1.00000E-06 ERROR (from ropp_io_fields_compare): Profile 1 Lev2a%dry_temp values ARE significantly different: |diff| = 4.80177E-04 > 1.00000E-04 INFO (from ropp_pp_compare): Differences occurred in profile 1 INFO (from ropp_pp_compare): 6 elements of ropp_pp_test_2m.nc and ../data/ropp_pp_test_2m_reference.nc differ significantly **************************** ********** *FAIL* ********** **************************** ... examine t_pp_occ_1.log for details Testing ROPP PP occ tool on GNOS data... Running t_pp_occ_gnos_1 (PP occ; GNOS data) ... ---------------------------------------------------------------------- ROPP PP File Comparison Tool ---------------------------------------------------------------------- INFO (from ropp_pp_compare): Comparing ropp_pp_test_gnos.nc and ../data/ropp_pp_test_gnos_reference.nc: the results of running test t_pp_occ_gnos_1 (PP occ; GNOS data) ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%lat_tp values ARE significantly different: |diff| = 7.96528E-02 > 1.00000E-04 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%lon_tp values ARE significantly different: |diff| = 8.16422E-02 > 1.00000E-04 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%azimuth_tp values ARE significantly different: |diff| = 3.53851E-02 > 1.00000E-02 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%impact values ARE significantly different: |diff| = 6.81258E+01 > 1.00000E+00 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%impact_opt values ARE significantly different: |diff| = 6.81258E+01 > 1.00000E+00 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%bangle values ARE significantly different: |diff| = 3.02321E-04 > 1.00000E-05 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%bangle_opt values ARE significantly different: |diff| = 3.02321E-04 > 1.00000E-06 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%impact_L1 values ARE significantly different: |diff| = 6.81258E+01 > 1.00000E+00 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%bangle_L1 values ARE significantly different: |diff| = 3.02321E-04 > 1.00000E-06 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%bangle_L1_sigma values ARE significantly different: |diff| = 2.05190E-04 > 1.00000E-06 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%impact_L2 values ARE significantly different: |diff| = 6.81258E+01 > 1.00000E+00 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%bangle_L2 values ARE significantly different: |diff| = 3.02321E-04 > 1.00000E-06 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%bangle_L2_sigma values ARE significantly different: |diff| = 2.05190E-04 > 1.00000E-06 ERROR (from ropp_io_fields_compare): Profile 1 Lev2a%refrac values ARE significantly different: |diff| = 1.18679E+00 > 1.00000E-06 ERROR (from ropp_io_fields_compare): Profile 1 Lev2a%dry_temp values ARE significantly different: |diff| = 1.81341E+00 > 1.00000E-04 ERROR (from ropp_io_fields_compare): Profile 1 Lev2a%alt_refrac values ARE significantly different: |diff| = 7.61035E+00 > 1.00000E+00 ERROR (from ropp_io_fields_compare): Profile 1 Lev2a%geop_refrac values ARE significantly different: |diff| = 7.61963E+00 > 1.00000E+00 INFO (from ropp_pp_compare): Differences occurred in profile 1 INFO (from ropp_pp_compare): 17 elements of ropp_pp_test_gnos.nc and ../data/ropp_pp_test_gnos_reference.nc differ significantly **************************** ********** *FAIL* ********** **************************** ... examine t_pp_occ_gnos_1.log for details Testing ROPP PP raw sampling tool... Running t_pp_rs_1 (PP raw sampling; default options) ... ---------------------------------------------------------------------- ROPP PP File Comparison Tool ---------------------------------------------------------------------- INFO (from ropp_pp_compare): Comparing ropp_pp_test_3m.nc and ../data/ropp_pp_test_3m_reference.nc: the results of running test t_pp_rs_1 (PP raw sampling; default options) ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%lat_tp values ARE significantly different: |diff| = 6.75507E-02 > 1.00000E-04 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%lon_tp values ARE significantly different: |diff| = 7.33986E-02 > 1.00000E-04 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%azimuth_tp values ARE significantly different: |diff| = 7.21436E-02 > 1.00000E-02 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%impact values ARE significantly different: |diff| = 2.68254E+01 > 1.00000E+00 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%impact_opt values ARE significantly different: |diff| = 2.68254E+01 > 1.00000E+00 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%impact_L1 values ARE significantly different: |diff| = 2.68254E+01 > 1.00000E+00 ERROR (from ropp_io_fields_compare): Profile 1 Lev1b%impact_L2 values ARE significantly different: |diff| = 2.68254E+01 > 1.00000E+00 ERROR (from ropp_io_fields_compare): Profile 1 Lev2a%refrac values ARE significantly different: |diff| = 6.41966E-04 > 1.00000E-06 ERROR (from ropp_io_fields_compare): Profile 1 Lev2a%dry_temp values ARE significantly different: |diff| = 6.81197E-04 > 1.00000E-04 INFO (from ropp_pp_compare): Differences occurred in profile 1 INFO (from ropp_pp_compare): 9 elements of ropp_pp_test_3m.nc and ../data/ropp_pp_test_3m_reference.nc differ significantly **************************** ********** *FAIL* ********** **************************** ... examine t_pp_rs_1.log for details Testing ROPP PP Abel transform and inversion... Running t_pp_abel_1 (PP Abel/Inv; default opts) ... **************************** ********** PASS ********** **************************** ... examine t_pp_abel_1.log for details Testing ROPP PP spectra tool... Running t_pp_spectra_1 (PP spectra; def opt) ... Comparing L1 dt spectra ... ---------------------------------------------------------------------- ROPP PP File Comparison Tool ---------------------------------------------------------------------- INFO (from ropp_pp_compare): Comparing ROanalysis_dt_L1.nc and ../data/ROanalysis_dt_L1_reference.nc: the results of running test t_pp_spectra_1a (PP spectra; def opt (L1 dt)) ERROR (from ropp_io_fields_compare): Profile 1 spectra_amp values ARE significantly different: |diff| = 1.14870E-02 > 1.00000E-05 INFO (from ropp_pp_compare): Differences occurred in profile 1 INFO (from ropp_pp_compare): 1 elements of ROanalysis_dt_L1.nc and ../data/ROanalysis_dt_L1_reference.nc differ significantly **************************** ********** *FAIL* ********** **************************** Comparing L2 dt spectra ... ---------------------------------------------------------------------- ROPP PP File Comparison Tool ---------------------------------------------------------------------- INFO (from ropp_pp_compare): Comparing ROanalysis_dt_L2.nc and ../data/ROanalysis_dt_L2_reference.nc: the results of running test t_pp_spectra_1b (PP spectra; def opt (L2 dt)) ERROR (from ropp_io_fields_compare): Profile 1 spectra_amp values ARE significantly different: |diff| = 3.26014E-03 > 1.00000E-05 INFO (from ropp_pp_compare): Differences occurred in profile 1 INFO (from ropp_pp_compare): 1 elements of ROanalysis_dt_L2.nc and ../data/ROanalysis_dt_L2_reference.nc differ significantly **************************** ********** *FAIL* ********** **************************** Comparing L1 ep spectra ... ---------------------------------------------------------------------- ROPP PP File Comparison Tool ---------------------------------------------------------------------- INFO (from ropp_pp_compare): Comparing ROanalysis_ep_L1.nc and ../data/ROanalysis_ep_L1_reference.nc: the results of running test t_pp_spectra_1c (PP spectra; def opt (L1 ep)) ERROR (from ropp_io_fields_compare): Profile 1 spectra_impact values ARE significantly different: |diff| = 1.52588E-05 > 1.00000E-06 ERROR (from ropp_io_fields_compare): Profile 1 spectra_amp values ARE significantly different: |diff| = 2.93732E-04 > 1.00000E-05 INFO (from ropp_pp_compare): Differences occurred in profile 1 INFO (from ropp_pp_compare): 2 elements of ROanalysis_ep_L1.nc and ../data/ROanalysis_ep_L1_reference.nc differ significantly **************************** ********** *FAIL* ********** **************************** Comparing L2 ep spectra ... ---------------------------------------------------------------------- ROPP PP File Comparison Tool ---------------------------------------------------------------------- INFO (from ropp_pp_compare): Comparing ROanalysis_ep_L2.nc and ../data/ROanalysis_ep_L2_reference.nc: the results of running test t_pp_spectra_1d (PP spectra; def opt (L2 ep)) ERROR (from ropp_io_fields_compare): Profile 1 spectra_impact values ARE significantly different: |diff| = 1.52588E-05 > 1.00000E-06 ERROR (from ropp_io_fields_compare): Profile 1 spectra_amp values ARE significantly different: |diff| = 1.19090E-04 > 1.00000E-05 INFO (from ropp_pp_compare): Differences occurred in profile 1 INFO (from ropp_pp_compare): 2 elements of ROanalysis_ep_L2.nc and ../data/ROanalysis_ep_L2_reference.nc differ significantly **************************** ********** *FAIL* ********** **************************** ... examine t_pp_spectra_1.log for details Testing ROPP PP wave optics propagator tool... Running t_pp_wopt_1 (PP WOPT; quick options) ... ---------------------------------------------------------------------- ROPP PP File Comparison Tool ---------------------------------------------------------------------- INFO (from ropp_pp_compare): Comparing ropp_pp_wopt_tool_out.nc and ../data/ropp_pp_wopt_tool_in.nc: the results of running test t_pp_wopt_1 (PP WOPT; quick options) **************************** ********** PASS ********** **************************** ... examine t_pp_wopt_1.log for details Making summary of test result ************************** SUMMARY OF ROPP_PP TEST RESULTS *************************** -------------------------------------------------------------------------------------- | Test name | Description | Run? | PASS? | -------------------------------------------------------------------------------------- | t_pp_invert_1 | PP invert; default options | Run | PASS | | t_pp_occ_1 | PP occ; default options | Run | *FAIL* | | t_pp_occ_gnos_1 | PP occ; GNOS data | Run | *FAIL* | | t_pp_rs_1 | PP raw sampling; default optio | Run | *FAIL* | | t_pp_abel_1 | PP Abel/Inv; def opts | Run | PASS | | t_pp_spectra_1a | PP spectra; def opt (L1 dt) | Run | *FAIL* | | t_pp_spectra_1b | PP spectra; def opt (L2 dt) | Run | *FAIL* | | t_pp_spectra_1c | PP spectra; def opt (L1 ep) | Run | *FAIL* | | t_pp_spectra_1d | PP spectra; def opt (L2 ep) | Run | *FAIL* | | t_pp_wopt_1 | PP WOPT; quick options | Run | PASS | --------------------------------------------------------------------------------------The differences are quite small, however. E.g. here are the diffs in
lon_tp,lat_tpandazimuth_tpfor the ropp_pp_occ_tool tests (c.f. the corresponding figure in #638):