Set time_offset in RO prof structure [1 d]

[Ian Culverwell]

https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_utils/build/Makefile.am https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_utils/coordinates/ecf2eci.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_utils/coordinates/eci2ecf.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_utils/coordinates/eci2eci.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_utils/coordinates/coordinates.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_utils/coordinates/occ_point.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_utils/coordinates/tangent_point.f90

Original changesets:

Set time_offset in RO prof structure: https://trac.romsaf.org/ropp/changeset/5202

[Ian Culverwell]

This innocuous change, including a necessary update to ropp_pp_wopt_tool.f90 has been made at r5910.

[Ian Culverwell]

Note that this change does not cause any failure in the make tests - because georef parameters are never tested in the pp tests. Even when this is switched on (in ropp_pp/tests/ropp_pp_compare.f90) it still doesn't fag a failure, because for some reason - probably oversight - georef%time_offset is not tested in ropp_io/ropp/ropp_io_fields_compare.f90 anyway. When this is fixed, we find, for example,

test_pp_occ.sh
 
Running t_pp_occ_1 (PP occ; default options) ...

----------------------------------------------------------------------
                     ROPP PP File Comparison Tool
----------------------------------------------------------------------

INFO (from ropp_pp_compare):  Comparing ropp_pp_test_2m.nc and ../data/ropp_pp_test_2m_reference.nc:
   the results of running test t_pp_occ_1 (PP occ; default options)
 
ERROR (from ropp_io_fields_compare):  Profile 1 GEOref%time_offset values values ARE significantly different: |diff| =      9.99991E+07 >  1.00000E-06
INFO (from ropp_pp_compare):  Differences occurred in profile 1
INFO (from ropp_pp_compare):  1 elements of ropp_pp_test_2m.nc and ../data/ropp_pp_test_2m_reference.nc differ significantly
****************************
********** *FAIL* **********
****************************
... examine t_pp_occ_1.log for details

because, as expected,

ncks -H -Q -vtime_offset ropp_pp_test_2m.nc
time_offset[0]=74.2271 

ncks -H -Q -vtime_offset ../data/ropp_pp_test_2m_reference.nc
time_offset[0]=-9.9999e+07 

[Ian Culverwell]

In all ropp_pp tests, the usual suspects fail:

************************** SUMMARY OF ROPP_PP TEST RESULTS ***************************
--------------------------------------------------------------------------------------
|                   Test name    |              Description       |    Run? |  PASS? |
--------------------------------------------------------------------------------------
|                  t_pp_invert_1 |     PP invert; default options |     Run |  PASS  |
|                     t_pp_occ_1 |        PP occ; default options |     Run | *FAIL* |
|                t_pp_occ_gnos_1 |              PP occ; GNOS data |     Run | *FAIL* |
|                      t_pp_rs_1 | PP raw sampling; default optio |     Run | *FAIL* |
|                    t_pp_abel_1 |          PP Abel/Inv; def opts |     Run |  PASS  |
|                t_pp_spectra_1a |    PP spectra; def opt (L1 dt) |     Run |  PASS  |
|                t_pp_spectra_1b |    PP spectra; def opt (L2 dt) |     Run |  PASS  |
|                t_pp_spectra_1c |    PP spectra; def opt (L1 ep) |     Run |  PASS  |
|                t_pp_spectra_1d |    PP spectra; def opt (L2 ep) |     Run |  PASS  |
|                    t_pp_wopt_1 |         PP WOPT; quick options |     Run | *FAIL* |
--------------------------------------------------------------------------------------

[Ian Culverwell]

The testing code changes have been committed at r5911. The reference files have been updated at r5912. Closing ticket.