Opened 6 years ago

Closed 3 years ago

#645 closed task (fixed)

Implemented option to remove Vlist data (independent of thinning) [2 h]

Reported by: Ian Culverwell Owned by: Ian Culverwell
Priority: normal Milestone: ROPP9.1 carry over
Component: aftermath Version: 11.0
Keywords: Cc:

Description

Implemented option to remove Vlist data (independent of thinning) https://trac.romsaf.org/ropp/changeset/5439/ropp_src/branches/dev/Share/dmi_trunk_9.0

Change history (1)

comment:1 by Ian Culverwell, 3 years ago

Resolution: fixed
Status: newclosed
Version: 9.011.0

DMI's change included a -s option to ropp2roppp, to set rmvlist=.TRUE. and then remove extra data, but then replaced

      IF (thfile /= "0") THEN
        IF (SIZE(ROdata%vlist) > 0) CALL ropp_io_free(ROdata%vlist)
      ENDIF

by

      IF ( rmvlist ) THEN
        IF (SIZE(ROdata%vlist) > 0) CALL ropp_io_free(ROdata%vlist)
      ENDIF

Better to keep the thinfile-dependent option and replace this by

      IF ( thfile /= "0" .OR. rmvlist ) THEN
        IF (SIZE(ROdata%vlist) > 0) CALL ropp_io_free(ROdata%vlist)
      ENDIF

because we have no idea if an ROPP user is taking advantage of the removal of extra data because a thinning file is being used.

Checks out OK.

Man page needs updating, but the user guide doesn't.

Code and man page committed at r6856.

Closing ticket.

Note: See TracTickets for help on using tickets.