Change location of roppbufrcodes.nl

[Ian Culverwell]

The ROPP-10.0 beta reviewers suggest:

The file roppbufrcodes.nl is installed into the directory defined by one of the
environment variables BUFR_TABLES (for the ECMWF BUFR library) or BUFR_LIBRARY
(for the MetOffice BUFR library). These environment variables are also used by
the respective library to point data files and bufr tables relevant for these
libraries. The namelist file, however, is not relevant for these libraries; it
is only used by a small number of ROPP tools. Therefore, they shouldn't be
installed into the directory trees of these libraries. A much better option
would be to put them into a path like <prefix>/share/ropp which would also be
more in line with the usual directory layout for automake/autoconf projects as
well as Unix software in general.

OK.

[Ian Culverwell]

They further say:

The same place ( <prefix>/share/ropp ) could also be used to install the EGM96
coefficient files rather than having the user to have to sort those files him-
or herself. We did not immediately find any reference to these files, actually,
in any README.

(There is in fact a brief reference to ropp_pp/data/egm96.dat (for GEOPOT_COEF) and ropp_pp/data/corrcoef.dat (for GEOPOT_CORR) in the grib2bgrasc man page, ropp_io/tools/grib2bgrasc.1.)

[olewis]

I have had a look at moving the location of the roppbufrcodes.nl file to another location as suggested. To make this change there are two files which will need to be edited, the bufr/Makefile.am and the bufr/convercodes.f90.

The Makefile.am is relatively straightforward to change and would require the references to BUFR_LIBRARY and BUFR_TABLE environments being updated to the new location (i.e. $PREFIX/share/ropp/). The error message write outs in this file would also all need to be updated.

The bufr/convertcodes.f90 file will also need to be updated. This currently makes use of a list of locations where the namelist could be found and this would need to be updated to either just add in the this new location to store the roppbufrcodes.nl file or to remove the BUFR_LIBRARY and BUFR_TABLE locations and just have the /share/ropp/ location. The convertcodes.f90 code has a list of environment variables which when put through the get_env function gets the data directory stored under that variable. This would mean for the new location a new environment variable name such as ROPPNAMELIST would need to be defined and exported to the environment. The description for this file would also need to be updated. Some other descriptions through out ROPP of the use of the roppbufrcodes.nl would also need to be updated.

The other thing which would need to be updated would be creating a the directory $PREFIX/share/ropp but I have not yet found where this would need to be included.

[Ian Culverwell]

Possibly included in I/O devts in ROPP-11.1.