Opened 4 years ago

Closed 4 years ago

#669 closed task (fixed)

roppbufrcodes.nl should be installed if ecCodes is used

Reported by: Ian Culverwell Owned by: Ian Culverwell
Priority: normal Milestone: 10.0
Component: ROPP(all) Version: 9.0
Keywords: Cc:

Description

ROPP-10.0 beta reviewers point out:

If eccodes is used as replacement for other BUFR libraries (in particular
bufrdc), the file roppbufrcodes.nl is not installed automatically, even if
BUFR_TABLES is set.

Sounds like an oversight that should be fixed before release.

Attachments (6)

buildpack_ropp_io_ecbufr (64.6 KB ) - added by Ian Culverwell 4 years ago.
buildpack_ropp_io_ecbufr
buildpack_ropp_io_mobufr_only (55.1 KB ) - added by Ian Culverwell 4 years ago.
buildpack_ropp_io_mobufr_only
buildpack_ropp_io_mobufr (64.9 KB ) - added by Ian Culverwell 4 years ago.
buildpack_ropp_io_mobufr
buildpack_ropp_io_eccodes_only (57.2 KB ) - added by Ian Culverwell 4 years ago.
buildpack_ropp_io_eccodes_only
buildpack_ropp_io_eccodes (70.3 KB ) - added by Ian Culverwell 4 years ago.
buildpack_ropp_io_eccodes
buildpack_ropp_io_ecbufr_only (63.2 KB ) - added by Ian Culverwell 4 years ago.
buildpack_ropp_io_ecbufr_only

Download all attachments as: .zip

Change history (7)

by Ian Culverwell, 4 years ago

Attachment: buildpack_ropp_io_ecbufr added

buildpack_ropp_io_ecbufr

by Ian Culverwell, 4 years ago

buildpack_ropp_io_mobufr_only

by Ian Culverwell, 4 years ago

Attachment: buildpack_ropp_io_mobufr added

buildpack_ropp_io_mobufr

by Ian Culverwell, 4 years ago

buildpack_ropp_io_eccodes_only

by Ian Culverwell, 4 years ago

Attachment: buildpack_ropp_io_eccodes added

buildpack_ropp_io_eccodes

by Ian Culverwell, 4 years ago

buildpack_ropp_io_ecbufr_only

comment:1 by Ian Culverwell, 4 years ago

Resolution: fixed
Status: newclosed

Updated ropp_io/bufr/Makefile.am, to include a section mirroring the ECBUFR installation step, at r6506. Logic: install roppbufrcodes.nl if any of {ecbufr, eccodes, mobufr} is present. (It's the same file in all cases.)

Checks out OK, at least for ifort17 - see the attached log files for the ropp_io build. Line 379 of buildpack_ropp_io_eccodes_only shows that, even if ecCodes is the only library available, the namelist is still installed in $ROPP_ROOT/bufr. I think this is probably good enough.

Closing ticket.

Note: See TracTickets for help on using tickets.