Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#670 closed task (fixed)

Write patch to amend ecCodes library manually

Reported by: Ian Culverwell Owned by: warrick
Priority: normal Milestone: 10.0
Component: ROPP(all) Version: 9.0
Keywords: Cc: Ian Culverwell

Description

ROPP10.0 beta reviewers say, in connection with changes needed to suppress the many, many errors like

ECCODES ERROR : encode_double_value: bendingAngle. Value (1.7e+38) out of range (minAllowed=-0.001,
maxAllowed=0.00948575). Setting it to missing value

that appear when using the ecCodes library:

Rather than verbally describing the required change, ROPP should also come with
a proper patch to avoid ambiguities in the written description.

This would also allow users to apply the fix to other ecCodes libraries, perhaps ones they have already been downloaded.

Attachments (1)

eccodes_patch (5.4 KB ) - added by warrick 4 years ago.
Shell script for patching ecCodes source

Download all attachments as: .zip

Change history (5)

comment:1 by warrick, 4 years ago

Resolution: fixed
Status: newclosed

A patch has been added at ropp_io/tools/eccodes_patch

It is a shell script which applies the changes needed to suppress the warning messages. Simply run the script, giving the path to your unpacked ecCodes source as an argument. The script then suggests that the user check a diff of the edited vs original file to make sure the change has been applied correctly.

by warrick, 4 years ago

Attachment: eccodes_patch added

Shell script for patching ecCodes source

comment:2 by warrick, 4 years ago

The patch was merged into the ROPP100_prototype branch at r6403 and edited at r6405

comment:3 by Ian Culverwell, 4 years ago

Further changes committed at r6485.

comment:4 by Ian Culverwell, 4 years ago

Added eccodes-2.12.5-Source/src/grib_accessor_class_bufr_data_array.c_original to ropp_deps/eccodes-2.12.5-Source.tar.gz at r6486.

Note: See TracTickets for help on using tickets.