Changed sign in EUM data reconstruction from I's and Q's [0.5 d]

[Ian Culverwell]

https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/ropp/ropp_io.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/ropp/ropp_io_read.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/ropp/ropp_io_read_ncdf_get.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/tools/eum2bufr_ec.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/tools/eum2ropp.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/tools/ropp2bufr_ec.f90 (similar/consistent updates to ropp2bufr_mo.f90 has not been made since https://trac.romsaf.org/ropp/changeset/3430)

Original changesets:

Changed sign in EUM data reconstruction from I's and Q's: https://trac.romsaf.org/ropp/changeset/5323/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/ropp/ropp_io_read_ncdf_get.f90

[Ian Culverwell]

Very happy to take Stig's guidance on this. It doesn't cause any problems in the automatic ropp_io tests because although t_eum2ropp.sh tests eum2ropp with the -l cl+rs option, which would cause the reader to pass through this bit of the code, our test dataset ropp_io/dataeum_test.n4 doesn't contain any raw sampling data:

idculv@eld037:> ncks -H -Q -v/quality/rs_data_available ../data/eum_test.n4
/quality/rs_data_available
rs_data_available = 0

and so in fact the modified code is bypassed.

[Ian Culverwell]

(We do have some cl data, however, so the test of eum2ropp -l cl+rs is not completely fatuous:

idculv@eld037:> ncks -H -Q -v/quality/cl_data_available ../data/eum_test.n4
/quality/cl_data_available
cl_data_available = 1

)

[Ian Culverwell]

And we don't currently have any tests of EUM lev 1a data in the ropp_pp module, which is why the change has no effect on that. I cannot remember if there are any tests of EUM level 1a data in the Test Folder - if there are, we will probably have to change them.

The whole question of ROPP test data and tests needs revising. Open #655 on the question.

Meanwhile, commit the change at r5940 and close ticket.