#587 closed task (fixed)
Changed valid range of alt_refrac and geop_refrac [1 h]
Reported by: | Ian Culverwell | Owned by: | Ian Culverwell |
---|---|---|---|
Priority: | normal | Milestone: | ROPP9.1 carry over |
Component: | ropp_io | Version: | 9.0 |
Keywords: | Cc: |
Description
Original changesets:
Changed valid range of alt_refrac and geop_refrac: https://trac.romsaf.org/ropp/changeset/4921/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/ropp/ropp_io_types.f90
Change history (5)
comment:1 by , 5 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:2 by , 5 years ago
Actually, it must have caused problems in the ropp_io tests, which I evidently didn't notice at the time. Testing of #585 shows that ucar2ropp fails because the new and reference netCDF files have different valid_range
s of alt_refrac
, geop_refrac
and shum_sigma
(the latter being introduced at r5919 in #551).
comment:3 by , 5 years ago
comment:4 by , 5 years ago
This also afftects the reference files for gfz2ropp
and ropp2bufr
. Update all of them at r5947.
comment:5 by , 5 years ago
It's concerning that I didn't spot these changes before. Perhaps I failed to rebuild ropp_io from scatch, so the changes to ropp_io/ropp/ropp_io_types.f90 weren't picked up. Anyway, it looks OK now, so keep the ticket closed.
This doesn't cause any downstream problems in ropp_io-dependent modules, so commit change at r5937. (No need to update ROPP IO user guide as it already claims
alt_refrac
andgeop_refrac
range from -1 to 150 km. Oops.) Closing ticket.