Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#587 closed task (fixed)

Changed valid range of alt_refrac and geop_refrac [1 h]

Reported by: Ian Culverwell Owned by: Ian Culverwell
Priority: normal Milestone: ROPP9.1 carry over
Component: ropp_io Version: 9.0
Keywords: Cc:

Description

Change history (5)

comment:1 by Ian Culverwell, 5 years ago

Resolution: fixed
Status: newclosed

This doesn't cause any downstream problems in ropp_io-dependent modules, so commit change at r5937. (No need to update ROPP IO user guide as it already claims alt_refrac and geop_refrac range from -1 to 150 km. Oops.) Closing ticket.

comment:2 by Ian Culverwell, 5 years ago

Actually, it must have caused problems in the ropp_io tests, which I evidently didn't notice at the time. Testing of #585 shows that ucar2ropp fails because the new and reference netCDF files have different valid_ranges of alt_refrac, geop_refrac and shum_sigma (the latter being introduced at r5919 in #551).

comment:3 by Ian Culverwell, 5 years ago

Actually, it's the valid range of shum_sigma, increased to [0, 50] g/kg at r5934 in #586, that the new tests have picked up. (The reference dataset was correctly updated as part of r5919.)

comment:4 by Ian Culverwell, 5 years ago

This also afftects the reference files for gfz2ropp and ropp2bufr. Update all of them at r5947.

comment:5 by Ian Culverwell, 5 years ago

It's concerning that I didn't spot these changes before. Perhaps I failed to rebuild ropp_io from scatch, so the changes to ropp_io/ropp/ropp_io_types.f90 weren't picked up. Anyway, it looks OK now, so keep the ticket closed.

Note: See TracTickets for help on using tickets.