Opened 7 years ago
Closed 2 years ago
#510 closed enhancement (fixed)
DMI wishlist for ROPP9.1/10.0
| Reported by: | Ian Culverwell | Owned by: | Ian Culverwell |
|---|---|---|---|
| Priority: | normal | Milestone: | ROPP9.1 carry over |
| Component: | ROPP (all) | Version: | 11.0 |
| Keywords: | Cc: |
Description (last modified by )
This ticket holds the DMI wishlist, emailed to me by Stig Syndergaard (DMI) on 6/3/2018. Subsequent tickets will record individual requests or sets of requests.
Hi Ian, When you see this first line, please prepare yourself that this is a very long email. Most probably the longest email you will ever receive from me ... ever! My apologies for the length of it up front. The first part of the email is to guide you through the rest, which is a bunch of links, links , and ... links, ... and more links. I hope the email can help in getting all or most of the changes in the dmi_trunk into a coming version of the official ROPP (that be 9.1 or 10.0). I guess there are no easy ways to do this unless you blindly merge everything we have in the dmi_trunk_9.0 into the ROPP trunk, and I don't think you want to do that. There are numerous changes to a total of 89 files, and that's even when I've subtracted unwanted stuff such as our attributes and all proporty changes. I regret that I haven't been able to forward changes to you more frequently. Preparing the reprocessing just took precedence. My starting point for the links below was this changeset: https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0 That gives all the files that were changed in the merge between the dmi_trunk_8.1 and a copy of ROPP 9.0 (the tag), which became dmi_trunk_9.0. Only those file changes in changeset 5427 that are relevant to you is listed in the links below, and each relevant file is listed only once. Clicking on a particular link from the 5427 changeset will give you all the differences between the dmi_trunk (after I did the merge) and ROPP 9.0 for that file. Note, that you may not be interested in all changes, e.g., our changes related to attributes. Files with changes related to attributes only, are not listed, but if you are interested, you can of course see them in the 5427 changeset. Besides dividing links into groups of ropp modules (except for the first section which I call 'build stuff' and the last which I call 'Merging aftermath'), I have also divided files in each module into groups of one or more files that I think could make sense to merge or work on separately from other file groups. The groups are separated by long '------' lines. Below each group of files from the 5427 changeset you find the original changesets in the past that resulted in the change of those files. Not all changesets may have affected all files, but as a group, these are the involved changesets. My hope is that this could make it easier for you, and give some overview. However, be aware that there may be other files involved across groups and modules in changesets. I think (almost) each group should be self-contained, meaning that if you merge all the changesets in a group together, the result should be able to build. An exception to that is the first group in 'build stuff'. That would have to be merged first to support some of the other changes made later in different modules. And obviously the 'Merging aftermath' should be last. Changesets are either shown as the whole set in the link, e.g., like https://trac.romsaf.org/ropp/changeset/4652, or if there is only one file in the changeset, the whole path to that file is shown in the link. The whole file path is also shown if it's the only relevant file in that changeset, e.g., because changes to other files were already in ROPP 9.0., or if other files in the same changeset contains unwanted stuff. You should then of course only merge that one file from the changeset. The same changeset may be mentioned more than once. Once merged via one group it should not cause harm to merge it again when working on another group. Of course, you can work in different ways, e.g., merging each changeset in the original chronological order independent of which group I have put it into, but I thought maybe then it will be more difficult to keep the overview of the accumulated changes made to each file. I wrote one-liners to describe changesets - mostly the commit comment, but in some cases shortened or rewritten. The one-liners may not fully describe all changes in all cases, it is just a few words that guided me in making this list - and perhaps they are helpful to you too. In rare cases I have not been good enough to keep attribute changes from other changes, which means, unfortunately, that you can not directly merge a few changesets without some manual inspection to remove unwanted attribute stuff. One such case is 'Adding option to ropp2ropp that allows file merging', which was done in the same changeset as 'Yet another round of attribute adjustments' (changeset 5203). Such bummers are rare. When inspecting the changes in ropp2bufr_ec.f90, I noticed that similar/consistent updates to ropp2bufr_mo.f90 has not been made since https://trac.romsaf.org/ropp/changeset/3430. Maybe we ought to also update ropp2bufr_mo.f90 with the many changes made to ropp2bufr_ec.f90 over the years, or perhaps, to avoid such maintenance headaches in the future, the two files could be made into one ropp2bufr.f90, with an option to choose either mo or ec, and with IF statements where coding differences are necessary. Just suggestions, I don't have plans to do it, but I'm willing to help. At the end there are a few additional changes under 'Merging aftermath'. They should be trivial to merge after everything else. Please ask any questions you may have. I gather that we will talk more about this over emails, next PTM, and/or next ROPP GG (or whatever that is called now). Best wishes, -Stig ________build stuff: -------------------------------------------------------------------------------------------------------------------------------- https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/build_deps https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/buildpack https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/configure/sofa_configure_ifort_linux https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_1dvar/configure.ac https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_apps/configure.ac https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/configure.ac https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/configure.ac https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/configure.ac https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_utils/configure.ac https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/sofa-20160503.tar.gz https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_svn_install.sh ____Original changesets: Make it possible to build dependency packages outside trunk: https://trac.romsaf.org/ropp/changeset/5189 Added a TOP to ecmwf bufr build: https://trac.romsaf.org/ropp/changeset/5190/ropp_src/branches/dev/Share/dmi_trunk_8.1/buildpack svn merge of hgl_sofa: https://trac.romsaf.org/ropp/changeset/5331 Changes to use eci2eci in ropp_io: https://trac.romsaf.org/ropp/changeset/5332 -------------------------------------------------------------------------------------------------------------------------------- https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/roppconfig No original changeset -------------------------------------------------------------------------------------------------------------------------------- ________ropp_1dvar: -------------------------------------------------------------------------------------------------------------------------------- https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_1dvar/tools/ropp_1dvar_bangle.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_1dvar/tools/ropp_1dvar_refrac.f90 ____Original changeset: Use --no-ranchk consistently (two dashes in front): https://trac.romsaf.org/ropp/changeset/4926 -------------------------------------------------------------------------------------------------------------------------------- https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_1dvar/errors/ropp_1dvar_add_bgr_error.f90 ____Original changesets: svn merge of jkn_dmi_trunk_8.1: https://trac.romsaf.org/ropp/changeset/5370/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_1dvar/errors/ropp_1dvar_add_bgr_error.f90 Merging a few changes from jkn_dmi_trunk_8.1 back into dmi_trunk_8.1: https://trac.romsaf.org/ropp/changeset/5414/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_1dvar/errors/ropp_1dvar_add_bgr_error.f90 -------------------------------------------------------------------------------------------------------------------------------- https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_1dvar/common/ropp_1dvar_diagnostics.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_1dvar/common/ropp_1dvar_read_config.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_1dvar/common/ropp_1dvar_types.f90 ____Original changeset: Defined new sub-variables j_s_limit and n_iter_limit: https://trac.romsaf.org/ropp/changeset/5068 -------------------------------------------------------------------------------------------------------------------------------- https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_1dvar/common/ropp_1dvar_covar_bg.f90 No original changeset -------------------------------------------------------------------------------------------------------------------------------- ________ropp_apps: -------------------------------------------------------------------------------------------------------------------------------- https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_apps/tools/ropp_apps_tph_tool.f90 ____Original changesets: Update of ropp_apps_tph_tool in Section 7: https://trac.romsaf.org/ropp/changeset/4875/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_apps/tools/ropp_apps_tph_tool.f90 Added a --no-ranchk option that controls range checking of the input: https://trac.romsaf.org/ropp/changeset/4922/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_apps/tools/ropp_apps_tph_tool.f90 Bug fix: https://trac.romsaf.org/ropp/changeset/4961/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_apps/tools/ropp_apps_tph_tool.f90 Do not set Level 2c surface values to 0 m and 1000 hPa: https://trac.romsaf.org/ropp/changeset/5201/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_apps/tools/ropp_apps_tph_tool.f90 -------------------------------------------------------------------------------------------------------------------------------- ________ropp_fm: -------------------------------------------------------------------------------------------------------------------------------- https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/build/Makefile.am https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/common/ropp_fm.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/refrac_1d/Makefile.am https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/refrac_1d/ropp_fm_tdry.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/refrac_1d/ropp_fm_tdry_1d.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/tools/ropp_fm_bg2ro_1d.f90 ____Original changesets: Implemented forward-modelling to Tdry: https://trac.romsaf.org/ropp/changeset/4652 Initializing lev1b and lev2a structures: https://trac.romsaf.org/ropp/changeset/4656/ropp_src/branches/dev/Share/dmi_trunk_8.0/ropp_fm/tools/ropp_fm_bg2ro_1d.f90 New routines to initialize the Obs1dRefrac and Obs1dBangle structures: https://trac.romsaf.org/ropp/changeset/4777/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_fm/tools/ropp_fm_bg2ro_1d.f90 Fixed a bug in the dry-temperature calculation: https://trac.romsaf.org/ropp/changeset/4861/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_fm/tools/ropp_fm_bg2ro_1d.f90 Add azimuth, radius of curvature, and center of curvature: https://trac.romsaf.org/ropp/changeset/4873/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_fm/tools/ropp_fm_bg2ro_1d.f90 Don't return exit code 1 when using the --no-ranchk option: https://trac.romsaf.org/ropp/changeset/4884/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_fm/tools/ropp_fm_bg2ro_1d.f90 Do not extrapolate above model top: https://trac.romsaf.org/ropp/changeset/4924/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_fm/refrac_1d/ropp_fm_tdry_1d.f90 Integrate hydrostatic equation only from second-most top level and down: https://trac.romsaf.org/ropp/changeset/5418/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_fm/refrac_1d/ropp_fm_tdry_1d.f90 -------------------------------------------------------------------------------------------------------------------------------- https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/common/ropp_fm_state2roprof.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/model_ecmwf/ropp_fm_state2state_ecmwf.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/model_ecmwf/ropp_fm_state2state_ecmwf_ad.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_fm/model_ecmwf/ropp_fm_state2state_ecmwf_tl.f90 ____Original changesets: Deactivated shum<0 checks in 1D-Var: https://trac.romsaf.org/ropp/changeset/5194 svn merge of jkn_dmi_trunk_8.1 https://trac.romsaf.org/ropp/changeset/5409 bug-fix: factor should be 1/2 instead of 1/e at top level: https://trac.romsaf.org/ropp/changeset/5417 -------------------------------------------------------------------------------------------------------------------------------- ________ropp_io: -------------------------------------------------------------------------------------------------------------------------------- https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/ncdf/ncdf_putgetvar_acode.m4 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/ncdf/ncdf_putgetvar_schar.m4 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/ncdf/ncdf_putgetvar_scode.m4 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/ncdf/ncdf_putvar.f90 ____Original changeset: Removed repeated synchronization when writing files: https://trac.romsaf.org/ropp/changeset/5281 -------------------------------------------------------------------------------------------------------------------------------- https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/ncdf/ncdf_create.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/ncdf/ncdf_error_handler.f90 ____Original changesets: Avoid infinite loop when 'Protocol error' occurs: https://trac.romsaf.org/ropp/changeset/5288/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/ncdf/ncdf_error_handler.f90 Avoid 'Protocol error' in vagrant environment: https://trac.romsaf.org/ropp/changeset/5289/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/ncdf/ncdf_create.f90 -------------------------------------------------------------------------------------------------------------------------------- https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/ropp/ropp_io_write_ncdf_def.f90 ____Original changeset: Added error handling after call to nf90_enddef: https://trac.romsaf.org/ropp/changeset/5290/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/ropp/ropp_io_write_ncdf_def.f90 -------------------------------------------------------------------------------------------------------------------------------- https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/tools/grib2bgrasc.f90 ____Original changesets: PCD bit 15 is now set in bgr files by the grib2bgrasc tool: https://trac.romsaf.org/ropp/changeset/4795/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/tools/grib2bgrasc.f90 Minor update of grib2bgrasc.f90: https://trac.romsaf.org/ropp/changeset/4874/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/tools/grib2bgrasc.f90 fcperiod is not well defined for interpolation: https://trac.romsaf.org/ropp/changeset/4960/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/tools/grib2bgrasc.f90 Adding requested date & time to the bgr file DTocc structure: https://trac.romsaf.org/ropp/changeset/5100/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/tools/grib2bgrasc.f90 Option --no-ranchk added to grib2bgrasc: https://trac.romsaf.org/ropp/changeset/5101/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/tools/grib2bgrasc.f90 Skipping mapping of lon to [0:360]: https://trac.romsaf.org/ropp/changeset/5102/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/tools/grib2bgrasc.f90 -------------------------------------------------------------------------------------------------------------------------------- https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/tools/ropp2ropp.f90 ____Original changesets: Do not warn on the use of --no-ranchk: https://trac.romsaf.org/ropp/changeset/4820 Adding option to ropp2ropp that allows file merging: https://trac.romsaf.org/ropp/changeset/5203/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/tools/ropp2ropp.f90 Bug-fix: https://trac.romsaf.org/ropp/changeset/5374/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/tools/ropp2ropp.f90 Added option -r to remove a processing level: https://trac.romsaf.org/ropp/changeset/5390/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/tools/ropp2ropp.f90 -------------------------------------------------------------------------------------------------------------------------------- https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/tools/ucar2ropp.f90 ____Original changesets: svn merge of dmi_trunk_8.0: https://trac.romsaf.org/ropp/changeset/4735/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/tools/ucar2ropp.f90 Do not warn on the use of --no-ranchk: https://trac.romsaf.org/ropp/changeset/4820 -------------------------------------------------------------------------------------------------------------------------------- https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/ropp/ropp_io.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/ropp/ropp_io_read.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/ropp/ropp_io_read_ncdf_get.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/tools/eum2bufr_ec.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/tools/eum2ropp.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/tools/ropp2bufr_ec.f90 (similar/consistent updates to ropp2bufr_mo.f90 has not been made since https://trac.romsaf.org/ropp/changeset/3430) ____Original changesets: Changes to make range checking optional: https://trac.romsaf.org/ropp/changeset/4272/ropp_src/branches/dev/Share/dmi_trunk_6.1/ropp_io/tools/eum2ropp.f90 Do not warn on the use of --no-ranchk: https://trac.romsaf.org/ropp/changeset/4820 Changes to handle Metop from UCAR: https://trac.romsaf.org/ropp/changeset/5016/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/ropp/ropp_io_read_ncdf_get.f90 Set PCD bit 2 (NRT/Offline) when reading UCAR atmPhs files: https://trac.romsaf.org/ropp/changeset/5067/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/ropp/ropp_io_read_ncdf_get.f90 Changed sign in EUM data reconstruction from I's and Q's: https://trac.romsaf.org/ropp/changeset/5323/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/ropp/ropp_io_read_ncdf_get.f90 Changes to use eci2eci in ropp_io: https://trac.romsaf.org/ropp/changeset/5332/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/ropp/ropp_io_read_ncdf_get.f90 Use 0.02 sec (cl and ol) or 0.001 sec (rs) assumed sampling times: https://trac.romsaf.org/ropp/changeset/5337/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/ropp/ropp_io_read_ncdf_get.f90 Do a propor average of SNRs (via I and Q): https://trac.romsaf.org/ropp/changeset/5344/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/ropp/ropp_io_read_ncdf_get.f90 Get date and time from level 1a instead of level 1b: https://trac.romsaf.org/ropp/changeset/5345/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/ropp/ropp_io_read_ncdf_get.f90 Remove samples with tracking state = 2 for setting, not rising: https://trac.romsaf.org/ropp/changeset/5349/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/ropp/ropp_io_read_ncdf_get.f90 Implemented option to get EUMETSATs navbit-corrected excess phase: https://trac.romsaf.org/ropp/changeset/5356 Implemented option to exclude output of the level 1b bending angle: https://trac.romsaf.org/ropp/changeset/5362 Metadata adjustments for eum2ropp: https://trac.romsaf.org/ropp/changeset/5363/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/ropp/ropp_io_read_ncdf_get.f90 Removed obsolete comments, added one: https://trac.romsaf.org/ropp/changeset/5367/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/ropp/ropp_io_read_ncdf_get.f90 Avoid core dump in very rare cases when ol and rs times don't match: https://trac.romsaf.org/ropp/changeset/5381/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/ropp/ropp_io_read_ncdf_get.f90 Modifications to read UCARs atmPrf files: https://trac.romsaf.org/ropp/changeset/5389/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/ropp/ropp_io_read_ncdf_get.f90 -------------------------------------------------------------------------------------------------------------------------------- https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/ropp/ropp_io_types.f90 ____Original changesets: Changed shum_sigma valid range from 5 g/kg to 50 g/kg: https://trac.romsaf.org/ropp/changeset/4877/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/ropp/ropp_io_types.f90 Changed valid range of alt_refrac and geop_refrac: https://trac.romsaf.org/ropp/changeset/4921/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/ropp/ropp_io_types.f90 Changed valid range of shum: https://trac.romsaf.org/ropp/changeset/5194/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_io/ropp/ropp_io_types.f90 -------------------------------------------------------------------------------------------------------------------------------- https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_io/bufr/ropp2bufr_mod.f90 No original changeset -------------------------------------------------------------------------------------------------------------------------------- ________ropp_pp: -------------------------------------------------------------------------------------------------------------------------------- https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/build/Makefile.am https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/bangle/ropp_pp_bending_angle_go.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/preprocess/ropp_pp_cutoff.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/preprocess/ropp_pp_preproc.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/preprocess/ropp_pp_preprocess.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/preprocess/ropp_pp_preprocess_champ.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/preprocess/ropp_pp_preprocess_cosmic.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/preprocess/ropp_pp_preprocess_grasrs.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/tools/ropp_pp_spectra_tool.f90 ____Original changesets: Changing maximum data gap size to 0.8: https://trac.romsaf.org/ropp/changeset/3207/ropp_src/branches/dev/Share/dmi_trunk/ropp_pp/preprocess/ropp_pp_preprocess_grasrs.f90 Changes to distinguish Metop from EUM and UCAR: https://trac.romsaf.org/ropp/changeset/4534/ropp_src/branches/dev/Share/dmi_trunk_8.0/ropp_pp/preprocess/ropp_pp_preprocess.f90 Allocated length of file name strings changed from 80 to 256: https://trac.romsaf.org/ropp/changeset/4535/ropp_src/branches/dev/Share/dmi_trunk_8.0/ropp_pp/tools/ropp_pp_spectra_tool.f90 Fatal error when navigation bit file is not found: https://trac.romsaf.org/ropp/changeset/4730/ropp_src/branches/dev/Share/dmi_trunk_8.0/ropp_pp/preprocess/ropp_pp_preprocess_cosmic.f90 Changes to handle Metop from UCAR: https://trac.romsaf.org/ropp/changeset/5016/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_pp/preprocess/ropp_pp_preprocess.f90 Adjusting message codes: https://trac.romsaf.org/ropp/changeset/5080 No open loop processing for METOP data from UCAR: https://trac.romsaf.org/ropp/changeset/5097/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_pp/preprocess/ropp_pp_preprocess.f90 Only info (not warning) when using non-open loop processing: https://trac.romsaf.org/ropp/changeset/5099/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_pp/preprocess/ropp_pp_preprocess.f90 Adding call to message_set_routine before Returns: https://trac.romsaf.org/ropp/changeset/5167 Set time_offset in RO prof structure: https://trac.romsaf.org/ropp/changeset/5202 Open loop resampling adjustments: https://trac.romsaf.org/ropp/changeset/5342/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_pp/preprocess/ropp_pp_preprocess_grasrs.f90 Make sure the uppermost grid point is inside the data interval: https://trac.romsaf.org/ropp/changeset/5343/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_pp/preprocess/ropp_pp_preprocess_grasrs.f90 Fail gracefully when closed loop data are missing: https://trac.romsaf.org/ropp/changeset/5347/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_pp/preprocess/ropp_pp_preprocess_grasrs.f90 Make sure that the new rs/ol grid is strictly within the rs/ol data: https://trac.romsaf.org/ropp/changeset/5348/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_pp/preprocess/ropp_pp_preprocess_grasrs.f90 Avoid undefined ts for very gappy open loop data: https://trac.romsaf.org/ropp/changeset/5354/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_pp/preprocess/ropp_pp_preprocess_grasrs.f90 Avoid erroneous ~0.019 sec gridding in some cases: https://trac.romsaf.org/ropp/changeset/5355/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_pp/preprocess/ropp_pp_preprocess_grasrs.f90 Implemented option to get EUMETSATs navbit-corrected excess phase: https://trac.romsaf.org/ropp/changeset/5356 Command-line options for paths to egm96, corr_egm96, and msisfile: https://trac.romsaf.org/ropp/changeset/5397/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_pp/tools/ropp_pp_spectra_tool.f90 Cut off last part of CHAMP and GRACE phase data: https://trac.romsaf.org/ropp/changeset/5398 -------------------------------------------------------------------------------------------------------------------------------- https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/bangle/ropp_pp_dct.f90 ____Original changesets: Adjusting message codes: https://trac.romsaf.org/ropp/changeset/5080 Introducing gradual transitions to avoid kinks in profiles: https://trac.romsaf.org/ropp/changeset/5164/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_pp/bangle/ropp_pp_dct.f90 -------------------------------------------------------------------------------------------------------------------------------- https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/preprocess/ropp_pp_correct_L2.f90 ____Original changesets: Changing parameters related to L2-extrapolation: https://trac.romsaf.org/ropp/changeset/5163/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_pp/preprocess/ropp_pp_correct_L2.f90 Fix smoothing-bug affecting only L2: https://trac.romsaf.org/ropp/changeset/5346/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_pp/preprocess/ropp_pp_correct_L2.f90 -------------------------------------------------------------------------------------------------------------------------------- https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/common/Makefile.am https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/common/ropp_pp.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/common/ropp_pp_diag2roprof.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/common/ropp_pp_interpolate_latlonaz.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/common/ropp_pp_read_config.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/common/ropp_pp_types.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/icorr/ropp_pp_fit_model_refraction.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/icorr/ropp_pp_fit_model_refraction_new.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/icorr/ropp_pp_ionospheric_correction.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/tools/ropp_pp_invert_tool.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/tools/ropp_pp_occ_tool.f90 ____Original changesets: Interpolation of lat, lon and azimuth: https://trac.romsaf.org/ropp/changeset/4607 New interpolation subroutine also needed in ropp_pp/build/Makefile.am: https://trac.romsaf.org/ropp/changeset/4608 Incorporation of ropp_pp_invert_tool in ropp_pp_occ_tool: https://trac.romsaf.org/ropp/changeset/4638/ropp_src/branches/dev/Share/dmi_trunk_8.0/ropp_pp/tools/ropp_pp_occ_tool.f90 svn merge of cb_tp_bending: https://trac.romsaf.org/ropp/changeset/4668 Use smt_ba as reference for lat_tp, lon_tp: https://trac.romsaf.org/ropp/changeset/4672/ropp_src/branches/dev/Share/dmi_trunk_8.0/ropp_pp/tools/ropp_pp_occ_tool.f90 Fixing problem with occ_point.f90 and tangent_point.f90: https://trac.romsaf.org/ropp/changeset/4674 Changed length of strings: https://trac.romsaf.org/ropp/changeset/4862/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_pp/common/ropp_pp_types.f90 Use --no-ranchk consistently (two dashes in front): https://trac.romsaf.org/ropp/changeset/4926 Writing SO fitting regression factors to diagnostics: https://trac.romsaf.org/ropp/changeset/4953 Command-line options for paths to egm96, corr_egm96, and msisfile: https://trac.romsaf.org/ropp/changeset/4971 Fixed bug that occasionally caused an error at the top: https://trac.romsaf.org/ropp/changeset/5065/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_pp/tools/ropp_pp_occ_tool.f90 Only add bangle_L1_sigma to err_neut when they are valid values: https://trac.romsaf.org/ropp/changeset/5066/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_pp/tools/ropp_pp_occ_tool.f90 Adjusting message codes: https://trac.romsaf.org/ropp/changeset/5080 Including check on derived impact parameter range: https://trac.romsaf.org/ropp/changeset/5161/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_pp/tools/ropp_pp_occ_tool.f90 Introducing opt_XL2 option: https://trac.romsaf.org/ropp/changeset/5165 Set time_offset in RO prof structure: https://trac.romsaf.org/ropp/changeset/5202 A little more control to avoid core dump in CT2: https://trac.romsaf.org/ropp/changeset/5360/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_pp/tools/ropp_pp_occ_tool.f90 Cosmetic edits: https://trac.romsaf.org/ropp/changeset/5395/ropp_src/branches/dev/Share/dmi_trunk_8.1/ropp_pp/tools/ropp_pp_occ_tool.f90 -------------------------------------------------------------------------------------------------------------------------------- https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/common/ropp_pp_tdry.f90 ____Original changeset: Minor changes in Tdry routines: https://trac.romsaf.org/ropp/changeset/4533/ropp_src/branches/dev/Share/dmi_trunk_8.0/ropp_pp/common/ropp_pp_tdry.f90 -------------------------------------------------------------------------------------------------------------------------------- https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/config/Makefile.am https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/config/champ_pp.cf https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/config/cosmic_pp.cf https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/config/default_pp.cf https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/config/grace_pp.cf https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/config/gras_pp.cf https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/config/grassaf_invert.cf https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/config/metop_pp.cf https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/config/romsaf_invert.cf https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/config/wopt_pp.cf ____Original changesets: Changes to reflect the ROM SAF processing: https://trac.romsaf.org/ropp/changeset/4969 Modified smoothing limits in config files: https://trac.romsaf.org/ropp/changeset/4974 We want tp_bending = true in the ROM SAF processing: https://trac.romsaf.org/ropp/changeset/5095 Changing filter width and other parameters: https://trac.romsaf.org/ropp/changeset/5166 Updated parameters for CHAMP and GRACE: https://trac.romsaf.org/ropp/changeset/5392 -------------------------------------------------------------------------------------------------------------------------------- https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_pp/tools/ropp_pp_wopt_tool.f90 No original changeset -------------------------------------------------------------------------------------------------------------------------------- ________ropp_utils: -------------------------------------------------------------------------------------------------------------------------------- https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_utils/build/Makefile.am https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_utils/coordinates/ecf2eci.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_utils/coordinates/eci2ecf.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_utils/coordinates/eci2eci.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_utils/coordinates/coordinates.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_utils/coordinates/occ_point.f90 https://trac.romsaf.org/ropp/changeset/5427/ropp_src/branches/dev/Share/dmi_trunk_9.0/ropp_utils/coordinates/tangent_point.f90 ____Original changesets: svn merge of cb_tp_bending: https://trac.romsaf.org/ropp/changeset/4668 Fixing problem with occ_point.f90 and tangent_point.f90: https://trac.romsaf.org/ropp/changeset/4674 Set time_offset in RO prof structure: https://trac.romsaf.org/ropp/changeset/5202 svn merge of hgl_sofa: https://trac.romsaf.org/ropp/changeset/5331 Avoid memory problems with large numbers of data: https://trac.romsaf.org/ropp/changeset/5353 -------------------------------------------------------------------------------------------------------------------------------- ________Merging aftermath: -------------------------------------------------------------------------------------------------------------------------------- Copy of one sample pos/vel has become obsolete in ROPP 9.0: https://trac.romsaf.org/ropp/changeset/5431/ropp_src/branches/dev/Share/dmi_trunk_9.0 -------------------------------------------------------------------------------------------------------------------------------- Get now also platform reference coordinates when running occ_point: https://trac.romsaf.org/ropp/changeset/5432/ropp_src/branches/dev/Share/dmi_trunk_9.0 -------------------------------------------------------------------------------------------------------------------------------- Implemented option to remove Vlist data (independent of thinning): https://trac.romsaf.org/ropp/changeset/5439/ropp_src/branches/dev/Share/dmi_trunk_9.0 -------------------------------------------------------------------------------------------------------------------------------- -- _________________________________________ Stig Syndergaard, PhD Danish Meteorological Institute Lyngbyvej 100 DK-2100 Copenhagen Phone: +45 39 157 408 E-mail: ssy@dmi.dk _________________________________________
Attachments (2)
Change history (10)
comment:1 by , 7 years ago
| Description: | modified (diff) |
|---|
comment:2 by , 6 years ago
| Milestone: | 9.1 → 9.1 carried over |
|---|
comment:4 by , 6 years ago
| Milestone: | → ROPP9.1 carry over |
|---|
comment:5 by , 6 years ago
A broken down list of these requests can be found in tickets 529-645 in the ROPP9.1 carry over milestone.
comment:7 by , 3 years ago
| Version: | 8.0 → 11.0 |
|---|
Leaving open as some of the ropp_pp tickets have not yet been closed.
comment:8 by , 2 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Stig's final (June 2022) comments on these can be found in the attached carryoverticketnotes.pdf.
My comments on these comments:
#530. OK, I think/assume you mean the 5189 -> 5190 change to build_ECBUFR in buildpack. I’ve included this in ROPP-11.1 at r7161.
#539. OK. As I say on the ticket, this is a good example of why changes need to be reviewed and tested, rather than unthinkingly accepted. Hopefully there will be more of this in CDOP4.
#548: OK, we can agree to differ. As I said, you’ll probably get lots of warnings (and therefor $RCs of 1) due to the absence of RoC in the input file. It might make a suitable item for inclusion in ROPP-12.0, subject to justification, review, discussion etc.
#550: OK. Penultimate loop could be included in ROPP-12.0.
#551: I haven’t got time to look into these. I suggest that they be raised in a ROPP-12.0 ticket.
#552: OK. I’m happy with what’s in ROPP-11.0+, but if you want to make it closer to ROPP110_DMI_changes at ROPP-12.0, then obviously that’s fine by me. (None of my business, in fact!)
#564: Note the fix that would work for DMI (changing msg_exit_warn) mentioned at the beginning of the ticket.
#608: PP UG updated with suggested text at r7206.
#633: Personally, I think automatic tests, and their concomitant reference files, are useful, because:
- They are a useful check against unintended consequences (i.e. that a change doesn’t affect something one wouldn’t expect it to affect);
- It’s a good (and usual) idea to run a code through a series of automatic tests, to check that it compiles and runs. Indeed, this happens when people build ROPP with buildpack, as they are recommended to do in the ROPP documentation. How else are they supposed to know that the code is running as expected? Previously, ROPP generated plots of results, which had to be compared (by eye!) to reference plots. No-one ever did. Surely a more precise numerical comparison to reference data is better? I know DMI don’t set much store by these automatic (“make test”) tests, but I suspect the > 960 ROPP registered users outside DMI might be reassured by a table of PASS/FAILs for each module. I certainly found a table of PASSes to be a useful necessary condition on the propriety of the code.
- There’s nothing wrong with updating the reference files in response to a change in the code (and it’s not hard to do), and the size of the difference between the test and the reference is a useful check for the developer that the change is behaving as expected.
- There may indeed be better (more precise, more comprehensive) means of testing. One can never do enough testing.
#694: Shifted to ROPP-12.0.
Finally closing ticket.
Note:
See TracTickets
for help on using tickets.
Shifted to new milestone ROPP9.1_carryover.